Skip to content

fix(vercel): mark header-only route entries as continue - #4651

Merged
pi0 merged 4 commits into
v2from
vercel-headers-continue
Sep 22, 2026
Merged

pi0 merged 4 commits into
v2from
vercel-headers-continue

Conversation

@danielroe

@danielroe danielroe commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

currently setting a headers route rule means we clobber any other rules, e.g. caching rules, and always fall to a function

discovered while debugging an issue with @larbish and @atinux

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe
danielroe requested a review from pi0 as a code owner September 22, 2026 10:26
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: b1f85734-6aab-4543-822a-208a6d74fd10

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
nitro.build Error Error Sep 22, 2026 9:47pm UTC

Request Review

@danielroe

Copy link
Copy Markdown
Member Author

cc: @pi0 we likely need to pin actions on v2 branch 🙏

Error: The actions actions/checkout@v6 and actions/setup-node@v6 are not allowed in nitrojs/nitro because all actions must be pinned to a full-length commit SHA.

@pkg-pr-new

pkg-pr-new Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/nitropack@4651

commit: ab4e4b0

Emit header-only routes least specific first so the more specific rule overrides, matching runtime route rule merging.
# Conflicts:
#	.github/workflows/autofix.yml
#	.github/workflows/ci.yml
@pi0
pi0 merged commit e7fb09c into v2 Sep 22, 2026
11 of 12 checks passed
@pi0
pi0 deleted the vercel-headers-continue branch September 22, 2026 21:57

This branch had an error being deployed

1 failed deployment
Preview — ab4e4b0f Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants