Repository navigation
[stable34] fix(lock): only return string app names from getAppName - #1396
Merged
Merged
Conversation
Backport of #1393. The test mocks ConfigService, which this branch still uses instead of IAppConfig. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
marked this pull request as ready for review
October 28, 2026 14:54
CI now picks PHP 8.5 for stable34, which psalm 5 does not support. Disable the unused code and override checks that are new in v6, as on main, and drop baseline entries and suppressions that are no longer needed. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
benjaminfrueh
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #1393. The test mocks
ConfigService, which this branch still uses instead ofIAppConfig.Also unblocks psalm, and with it every Dependabot PR on stable34: