Skip to content

[stable34] fix(lock): only return string app names from getAppName - #1396

Merged
juliusknorr merged 2 commits into
stable34from
backport/1393/stable34
Oct 28, 2026
Merged

juliusknorr merged 2 commits into
stable34from
backport/1393/stable34

Conversation

@juliusknorr

@juliusknorr juliusknorr commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Backport of #1393. The test mocks ConfigService, which this branch still uses instead of IAppConfig.

Also unblocks psalm, and with it every Dependabot PR on stable34:

  • psalm v6: CI now runs PHP 8.5, which psalm 5 does not support. Unused code and override checks off as on main, stale baseline entries and suppressions dropped

Backport of #1393. The test mocks ConfigService, which this branch still uses instead of IAppConfig.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
juliusknorr marked this pull request as ready for review October 28, 2026 14:54
CI now picks PHP 8.5 for stable34, which psalm 5 does not support. Disable the unused code and override checks that are new in v6, as on main, and drop baseline entries and suppressions that are no longer needed.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Julius Knorr <jus@bitgrid.net>
@juliusknorr
juliusknorr merged commit e5c48a9 into stable34 Oct 28, 2026
47 checks passed
@juliusknorr
juliusknorr deleted the backport/1393/stable34 branch October 28, 2026 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants