Repository navigation
fix(lock): only return string app names from getAppName - #1393
Merged
Merged
Conversation
A localized <name> in info.xml makes getAppInfo() return an array, which threw a TypeError on the ?string return type. Drop the misleading psalm annotation and only return string names. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Julius Knorr <jus@bitgrid.net>
juliusknorr
marked this pull request as ready for review
October 28, 2026 14:35
This was referenced Oct 28, 2026
Member
Author
|
/backport to stable35 |
benjaminfrueh
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A localized
<name>in an app's info.xml makesIAppManager::getAppInfo()return an array, sogetAppName()threw a TypeError on its?stringreturn type. The@var array{name: null}annotation on main and stable35 only hid that from psalm. On stable32 to stable34 psalm fails on this line, which blocks every Dependabot PR there.tests/Unit/Service/LockServiceTest.phpBackports: stable35 via backportbot. stable32 to stable34 will be done by hand, since the test needs a different constructor mock there (
ConfigServiceinstead ofIAppConfig).