Repository navigation
Fix failing MusicXml_Tests.glissandoStyle: update its reference for the new order of styled line properties - #35223
Conversation
…y order musescore#35118 changed the order in which a line's styled properties are written, and musescore#35186 added this reference with the old order; each passed on its own, and since both were merged MusicXml_Tests.glissandoStyle fails. Only the place of <glissandoStyle> in the glissando changes. Assisted-by: Claude Opus 5.5
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to
|
CI is failing because of the test added by my recent commit, and another change that got merged meanwhile. I had Claude Opus 5.5 do a quick fix. AI writeup below.
-ragesoss
No issue:
MusicXml_Tests.glissandoStylefails onmain(for example in the unit-test run of #35219: https://github.com/musescore/MuseScore/actions/runs/38433065427).#35186 added this test with a reference file saved before #35118 (Refactor SLine styled properties) was merged. #35118 changed the order in which a line's styled properties are written, so a glissando's
<glissandoStyle>is now saved after<diagonal>instead of right after<text>. Each PR passed its checks on its own; they were merged about an hour apart. This moves that one line intestGlissandoStyle_ref.mscx; nothing else changes.Checked with
iex_musicxml_testsbuilt frommain(d61794c):glissandoStylefails there, and with this reference all 364 MusicXML tests pass.Complete only if applicable:
🤖 Generated with Claude Code