chore: Update experimental module detection test and pin exact Node versions - #5407
Closed
mark-wiemer wants to merge 7 commits into
Closed
chore: Update experimental module detection test and pin exact Node versions#5407mark-wiemer wants to merge 7 commits into
mark-wiemer wants to merge 7 commits into
Conversation
mark-wiemer
commented
Jul 28, 2025
mark-wiemer
changed the title
mark-wiemer
marked this pull request as draft
July 28, 2025 18:58
mark-wiemer
marked this pull request as ready for review
July 28, 2025 22:57
Member
Author
|
Seems GitHub is having a minor brownout right now, all CI failures are failures to publish to Coveralls, which uses GitHub servers, and response is basically "no server available right now" or "sorry, this page it taking too long to load, try again later". The actual tests are passing, this PR is now ready for review :) |
5 tasks
3 tasks
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
This experimental feature on older versions of Node failed on our simple file, but newer versions of Node are better and now run the ambiguous files successfully. Tests were failing on newer Node versions because we expected Node to fail. This PR adds a version check for Node and expects it to behave consistently according to its version.
Also pins exact versions of Node consistently per #5052