fix: use original require() error for TS files if ERR_UNKNOWN_FILE_EXTENSION - #5408
Merged
JoshuaKGoldberg merged 9 commits intoSep 30, 2025
Merged
Conversation
JoshuaKGoldberg
changed the title
mark-wiemer
requested changes
Jul 29, 2025
mark-wiemer
reviewed
Jul 29, 2025
JoshuaKGoldberg
added
the
status: blocked
Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
JoshuaKGoldberg
removed
the
status: blocked
JoshuaKGoldberg
commented
Sep 1, 2025
JoshuaKGoldberg
commented
Sep 25, 2025
3 tasks
5 tasks
Member
Author
|
cc @mark-wiemer - none of the test failures are unique to this PR. I filed #5467. |
mark-wiemer
approved these changes
Sep 30, 2025
5 tasks
4 tasks
3 tasks
3 tasks
lennonnikolas
pushed a commit
to lennonnikolas/mocha
that referenced
this pull request
Jan 24, 2026
…TENSION (mochajs#5408) * fix: use original require() error if ERR_UNKNOWN_FILE_EXTENSION * Update lib/nodejs/esm-utils.js Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com> * Add in comments * test: add broken-syntax.ts fixture and test * chore: reset a change to main * test: slightly improve name --------- Co-authored-by: Mark Wiemer <7833360+mark-wiemer@users.noreply.github.com>
5 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
ERR_UNKNOWN_FILE_EXTENSION#5393status: accepting prsOverview
Adds in a special-case
try/catch->throw. If the file being imported is a.cts,.mts, or.tsand the caught error fromimport()is for an unknown file extension, we know it's from a Node.js version that doesn't support those file extensions. In that case we'll want to throw the original informativerequire()error per #5393.💖