Repository navigation
Pin System.Security.Cryptography.Pkcs to 10.0.13 for GHSA-846f-f764-76mx / GHSA-2fmv-rv2c-59x7 - #1079
Conversation
…6-84008 NuGet.Packaging 7.9.0 brings in 8.0.1, which the advisories published on 2026-10-13 flag, so restore fails with TreatWarningsAsErrors. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟢 Approval recommended
Restore, dependency resolution, Release build, NativeAOT publish, and executable startup all succeeded with Pkcs 10.0.13.
0 open findings
What changed in this PR
Pins a patched Pkcs dependency to prevent NuGet audit failures caused by NuGet.Packaging 7.9.0.
Changes:
- Adds a direct Pkcs package reference.
- Centrally pins version 10.0.13 with removal guidance.
| File | Description |
|---|---|
src/winapp-CLI/WinApp.Cli/WinApp.Cli.csproj |
References the patched package directly. |
src/winapp-CLI/Directory.Packages.props |
Pins Pkcs 10.0.13. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Build Metrics ReportValidation passed. All required build and validation jobs succeeded. Binary Sizes
.NET Test Results (TRX reports)Other suites are reflected in the overall validation status above. ✅ 8668 passed, 39 skipped out of 8707 tests in 2174.9s (+199.2s vs. baseline) Test Coverage✅ 87.5% line coverage, 81.9% branch coverage · ✅ no change vs. baseline CLI Startup Time72ms median (x64, Try This BuildInstalls the MSIX for your architecture, replacing any previously installed build. Needs the GitHub CLI — the command offers to install it and sign you in if it is missing. & ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) 1079Switching between builds often?Put the tool on your PATH once: & ([scriptblock]::Create((irm https://raw.githubusercontent.com/microsoft/winappCli/main/scripts/winapp-pr.ps1))) -AddToPathThen this build is just: winapp-pr 1079Run Updated 2026-10-14 09:35:34 UTC · commit |
Picks up the System.Security.Cryptography.Pkcs pin (#1079) that the failing restore needs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 72820671-e2ef-4a9e-b4e6-ddbb5679a467
What and why
Two new advisories (published 2026-10-13) affect System.Security.Cryptography.Pkcs 8.0.0 to 8.0.1, patched in 8.0.2 and 10.0.13:
NuGet.Packaging 7.9.0 brings in Pkcs 8.0.1 transitively. NuGet audit reports it as NU1902/NU1903, and
TreatWarningsAsErrorsturns those into restore failures.build-and-packagealready fails this way on open PRs (for example #1080):This PR pins Pkcs to 10.0.13 in
Directory.Packages.propsand references it fromWinApp.Cli.csproj.Upstream status, and when to remove the pin
The real fix belongs in NuGet.Packaging, and it hasn't shipped yet:
Remove this pin once winapp updates to a NuGet.Packaging release that depends on Pkcs 8.0.2 or later (or 10.0.13+). Check with
dotnet nuget why src/winapp-CLI/WinApp.Cli/WinApp.Cli.csproj System.Security.Cryptography.Pkcs.We pin rather than suppress NU1902/NU1903 or relax
TreatWarningsAsErrors, so the next real advisory still fails the build.Before / after
Nothing a user runs or sees changes. Restore resolves Pkcs 10.0.13 instead of 8.0.1.
Not tested / risks
NuGet audit data may not reproduce the warnings locally; CI is the real check.
Checklist
dotnet restore --force-evaluate -p:TreatWarningsAsErrors=trueand a Release build withTreatWarningsAsErrorspass;dotnet nuget whyresolves only Pkcs 10.0.13.