Repository navigation
Conversation
1 task done
zateutsch
pushed a commit
to microsoft/winappCli
that referenced
this pull request
Oct 14, 2026
/ GHSA-2fmv-rv2c-59x7 (#1079) ## What and why Two new advisories (published 2026-10-13) affect System.Security.Cryptography.Pkcs 8.0.0 to 8.0.1, patched in 8.0.2 and 10.0.13: - GHSA-846f-f764-76mx (CVE-2026-84008, high): .NET denial of service - GHSA-2fmv-rv2c-59x7 (CVE-2026-70162, medium): .NET denial of service NuGet.Packaging 7.9.0 brings in Pkcs 8.0.1 transitively. NuGet audit reports it as NU1902/NU1903, and `TreatWarningsAsErrors` turns those into restore failures. `build-and-package` already fails this way on open PRs (for example #1080): ``` error NU1903: Warning As Error: Package 'System.Security.Cryptography.Pkcs' 8.0.1 has a known high severity vulnerability, GHSA-846f-f764-76mx error NU1902: Warning As Error: Package 'System.Security.Cryptography.Pkcs' 8.0.1 has a known moderate severity vulnerability, GHSA-2fmv-rv2c-59x7 ``` This PR pins Pkcs to 10.0.13 in `Directory.Packages.props` and references it from `WinApp.Cli.csproj`. ## Upstream status, and when to remove the pin The real fix belongs in NuGet.Packaging, and it hasn't shipped yet: - Reported upstream: NuGet/Home#15103 (open). - Fix proposed: NuGet/NuGet.Client#7773 (open, not yet reviewed) bumps the Pkcs dependency. **Remove this pin** once winapp updates to a NuGet.Packaging release that depends on Pkcs 8.0.2 or later (or 10.0.13+). Check with `dotnet nuget why src/winapp-CLI/WinApp.Cli/WinApp.Cli.csproj System.Security.Cryptography.Pkcs`. We pin rather than suppress NU1902/NU1903 or relax `TreatWarningsAsErrors`, so the next real advisory still fails the build. ## Before / after Nothing a user runs or sees changes. Restore resolves Pkcs 10.0.13 instead of 8.0.1. ## Not tested / risks NuGet audit data may not reproduce the warnings locally; CI is the real check. ## Checklist - [x] Tested locally on Windows: `dotnet restore --force-evaluate -p:TreatWarningsAsErrors=true` and a Release build with `TreatWarningsAsErrors` pass; `dotnet nuget why` resolves only Pkcs 10.0.13. Co-authored-by: Nikola Metulev <711864+nmetulev@users.noreply.github.com> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Member
Member
|
Closing per Andy's comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Fixes: NuGet/Home#15103
Description
When I reference the latest version of NuGet.PackageManagement (7.9.0), I get:
PR Checklist