Repository navigation
[rel/4.5] Stabilize IPC disconnect test EOF rendezvous - #12289
Merged
Amaury Levé (Evangelink) merged 1 commit intoNov 9, 2026
Merged
Conversation
Port only the IPC test portion of #12252 (upstream 19c516f). Observe server-side transport EOF while the reply is gated; retain exact request, closure diagnostic and server-loop completion assertions. No production, controller-host fixture, CI, API, package or scheduling changes. The full IPC class passes 48 Windows executions across net8/net9/net462 and 32 Ubuntu executions across net8/net9, plus 20 Ubuntu repetitions. Byte-identical repaired tests reject an intentionally wrong closure diagnostic on both platforms and pass after production restoration. This is retained fault sensitivity, not reproduction of the original intermittent timeout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink)
enabled auto-merge (squash)
November 9, 2026 18:25
Amaury Levé (Evangelink)
disabled auto-merge
November 9, 2026 18:38
Amaury Levé (Evangelink)
deleted the
evangelink-rel-4-5-ipc-test-rendezvous
branch
November 9, 2026 18:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport only the five-line IPC-test slice of #12252. After disposing the idle client, observe and assert server-side transport EOF while the reply callback remains gated, then release the response. The exact request, closure diagnostic and server-loop completion assertions, per-test resources, and finally cleanup are unchanged.
Relates to #12287, without closing it. This is one independent, squashable commit targeting
rel/4.5: one file, five additions, no deletions. No controller-host fixture, Retry, production, API, package, target, CI or scheduler changes.Provenance
19c516fe2735245f71141e16dc0456c9257269bd(Stabilize MTP disconnect and controller-host tests #12252).826ef0f11a51e59861ceeb6e994917587add82d5(original parent601527fac8ea3e03811f0a433093b7a10099e3ce); existing message and coauthor preserved.f94ac669396629b6736fe92e7031c5e47c03adc6, sole parenta39964ce2cf09c4abcbaa7bb8f4e5818638a9de3(rel/4.5).6e0a6ec01057dcf25d2b78efcfbc84c6bb8fd16a. Source UTF-8 BOM preserved.Fresh validation on this release base
Both targeted repo-script builds passed with zero warnings/errors and distinct binlogs, using the pinned
12.0.100-alpha.1.26480.103SDK in this checkout's private.dotnet. All 30 TRX/JUnit/CTRF reports were parsed: 80 baseline and 80 corrected cases passed, none failed/skipped.SingleConnectionNamedPipeServer_ClientDisconnectsBeforeReply_LogsConciseClosureexecuted and passed exactly once in every run; all retained 32 workers, MethodLevel. WSL ran the same freshly Windows-built portable IL on the installed Linux runtimes, not a separate Linux build.This is a test-arrangement stability change, not a reproduced product regression. The original intermittent timeout was not reproduced, and fault injection was not rerun on this release base. Earlier validation described in the inherited commit message is not counted in these fresh results. No repack or acceptance run was needed for this test-only slice.
Standalone validation commands and results
The following reproduces the executed build/host arguments from the checkout root, with checkout-relative host paths and unique binlog paths. Baseline ran at
a39964ce2cf09c4abcbaa7bb8f4e5818638a9de3; corrected ran after rebuildingf94ac669396629b6736fe92e7031c5e47c03adc6. Each phase used its own matching binaries.Windows host commands, run separately for each phase after building the matching commit:
Inside the existing Ubuntu WSL distribution, from the mounted checkout root:
The first no-restore build attempt reported the missing Arcade toolset; the successful baseline command above restored it and the required local toolchain.