Repository navigation
Backport MSTest and MTP servicing fixes to rel/4.5 - #12287
Amaury Levé (Evangelink) wants to merge 4 commits into
Conversation
Adapt #12241 (f76d452) across Core, Retry, TRX and both release PackagedApp controller layouts. Preserve compatibility overloads, release framework assets and existing SDK wire models; retain focused upstream failure-path and package-consumer regressions. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Apply the servicing follow-up from #12225 (upstream b3f3c98) on top of the original #12220 release isolation fix. Preserve release file layout and targets, cleanup ownership/deadlines, independent failures and Framework aggregate messages. Retained tests execute against actual prior production: 12 of 136 lifecycle cases and 4 of 13 packed consumers fail for the intended missing corrections. Corrected code passes 732 focused unit executions, all 13 packaged consumers, and both 10-case source-generation opt-out plans. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Port only the IPC test portion of #12252 (upstream 19c516f). Observe server-side transport EOF while the reply is gated; retain exact request, closure diagnostic and server-loop completion assertions. No production, controller-host fixture, CI, API, package or scheduling changes. The full IPC class passes 48 Windows executions across net8/net9/net462 and 32 Ubuntu executions across net8/net9, plus 20 Ubuntu repetitions. Byte-identical repaired tests reject an intentionally wrong closure diagnostic on both platforms and pass after production restoration. This is retained fault sensitivity, not reproduction of the original intermittent timeout. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Superseded at the author's request by four independent, single-commit PRs so each backport can be squash-merged separately. All target
Verified the four independent commit trees and sole release parents; their disjoint 10/27/6/1-file scopes exactly preserve this PR's 44-file bundle. Each replacement has fresh standalone validation and documented remaining gaps. Closing this combined PR without merging; its branch and commit history are retained. No PR was merged or put on auto-merge. |
This comment has been minimized.
This comment has been minimized.
|
Final test-triage resolution — Azure Pipelines build 1671144 Conclusion: deterministic test failure tied to this PR (high confidence); no issue created. Signature:
Not actionable:
Evidence completeness: the evidence is complete. History covered 0 prior builds, so I can't say whether this signature has occurred before on main. A durable issue would need recurrence on main or scheduled builds. Next step: run
|
Bring the remaining selected MSTest and Microsoft.Testing.Platform servicing fixes to
rel/4.5: avoid unnecessary fixture-discovery assembly loads, publish each Retry TRX once at its final path, and preserve cleanup ownership and failure diagnostics. Also include the IPC disconnect test's deterministic EOF rendezvous.Target and scope:
rel/4.5, based ona39964ce2cf09c4abcbaa7bb8f4e5818638a9de3. The live release comparison is four commits and 44 files; this is not the much larger comparison againstmain.Backports
039c61b6c880b7a54b9bafb5cf9c6d67ab7005d06be7eec3169d5324fdcf75c425b5e0e16a46fadf601527fac8ea3e03811f0a433093b7a10099e3ce826ef0f11a51e59861ceeb6e994917587add82d5These are adapted servicing ports, not wholesale main-branch cherry-picks. Keep the release's .NET 8/.NET 9, Framework, UWP and WinUI targets and existing public/shipped API baselines. Fixture metadata inspection adds System.Reflection.Metadata 8.0.0 for the older targets that need it. Retry compatibility overloads remain; additive internal members are tracked.
Rationale and binding/compatibility decisions are in the fixture discovery decision record and the originating PRs above. Main-only retargeting, F# changes, coverage protocol changes, the controller-host fixture portion of #12252, and optional CI changes #12237/#12251 are excluded.
Validation
Product validation is bound to
601527fac8ea3e03811f0a433093b7a10099e3ce. The final head826ef0f11a51e59861ceeb6e994917587add82d5adds only the separately validated IPC test setup; shipping sources and packages are unchanged.Test-value evidence
PassiveProvidersAreDiscoveredWithoutExecutingReferenceMethods,UnmarkedDependenciesRemainUnloadedAndDeletable, custom-ALC/Framework binding cases and existing provider controls: 82 packaged cases pass. The eager-loading counterfactual executes the same 82 cases and fails 24 intended loading/intermediary assertions; 58 compatibility controls pass.RetryTrx_PersistentFailure,RetryTrx_Recovery, bothRetryTrx_Native*cases, threshold/disabled/absolute-path/attachment cases and CTRF/HTML/JUnit controls: 17 pass. Copy-only behavior fails eight duplicate-report assertions. Independently restoring old Core notification behavior fails both native stale-path assertions.TestMethodInfoTests,TestResultTests,GlobalCleanup_PreservesLocalTimeoutWhenGlobalCleanupThrowsandNetFrameworkCleanupFailureMessagesRetainBothMethodIdentities: 732 focused unit executions and 13 packaged consumers pass. Actual pre-review production with the same tests compiles/packs and fails 12 lifecycle and four consumer assertions; remaining controls pass.SingleConnectionNamedPipeServer_ClientDisconnectsBeforeReply_LogsConciseClosure: unchanged Windows baseline passes 48 cases. Repaired tests pass 80 Windows/Ubuntu class executions and 20 Linux repetitions. Holding tests byte-identical and appending a diagnostic marker produces the intended exact-equality failure on both platforms, exit 2; restoring production makes the full class pass again on both, exit 0. This is diagnostic fault sensitivity, not reproduction of the original intermittent timeout.Counterfactuals retained the regression tests and their dependencies. Restore/build/launch failures, zero-test runs and skipped controls are not counted as behavioral proof. Detailed patches, hashes, binlogs and reports are retained locally, not publicly attached.
Executed commands and results
All commands used Release configuration. Repository builds used the bootstrapped pinned SDK
12.0.100-alpha.1.26480.103. Machine-local results roots and unique binlog filenames are parameterized below; the consumer filters and runner arguments are preserved.The separate real SDK 10 run used SDK 10.0.401 selected from an isolated SDK root/working directory, a generated ordinary consumer rebuilt against fresh final-package bits, and
METHOD1=1,RESULTDIR=<results>.FAIL=0passed with exit 0;FAIL=1produced the expected persistent-failure exit 2:Remaining validation gaps
Actual AppX activation is blocked locally by the non-elevated environment and an existing preflight
installationPatherror. Controller package/layout verification is not activation proof. Hosted Azure DevOps/IDE rendering and CI for the published head have not been verified. No auto-merge is requested.No visual media is attached: the relevant evidence is executable assembly-loading, lifecycle, report-identity and path assertions rather than a UI/layout change. Temporary comparison worktrees, the isolated native consumer/cache and temporary SDK were removed safely; shared caches and the parent toolchain were left intact.