Repository navigation
[symbolmap] Map per-service-call history persistence option - #1225
Merged
Quim Muntal (qmuntal) merged 2 commits intoOct 1, 2026
Merged
Quim Muntal (qmuntal) merged 2 commits into
Quim Muntal (qmuntal) merged 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
approved these changes
Sep 30, 2026
Quim Muntal (qmuntal)
marked this pull request as ready for review
September 30, 2026 18:17
Quim Muntal (qmuntal)
enabled auto-merge
September 30, 2026 18:17
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The mapping matches the verified .NET and Go declarations and includes valid pinned review metadata.
Review effort: Balanced
Findings: None
What changed in this PR
Adds the .NET per-service-call history persistence option to the Go SDK symbol mapping.
Changes:
- Maps the .NET option to
agent.Config.RequirePerServiceCallHistoryPersistence. - Adds pinned review provenance for the mapping.
| File | Description |
|---|---|
docs/dotnet-go-sdk-symbol-mapping.json |
Adds the reviewed history-persistence mapping and provenance. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 1, 2026
Member
|
Copilot resolve conflicts |
…tory-persistence-20260929-b097fe53d087c098 # Conflicts: # docs/dotnet-go-sdk-symbol-mapping.json Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>
Quim Muntal (qmuntal)
approved these changes
Oct 1, 2026
Quim Muntal (qmuntal)
enabled auto-merge
October 1, 2026 04:55
Contributor
Conflicts with |
Quim Muntal (qmuntal)
deleted the
copilot/symbolmap-history-persistence-20260929-b097fe53d087c098
branch
October 1, 2026 05:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reviewed the supplied weekly symbolmap inputs starting at 2026-09-29T16:28:58Z with original
assessed-mappings.jsonpage.total = 839. Added review batchhistory-persistence-go-2026-09-29, pinned to .NET assembly metadata commit0c9944cc9f577d51277ac7c55dbc388b60a577af, current Go commit2b10117e67ea22a730c176567117537b720f45e0, and unchanged inventory SHA-256734ff2c4037aa311de95912a256bb7e223ab3fa81a699835a21d27bab90f53ab.ChatClientAgentOptions.RequirePerServiceCallChatHistoryPersistencemappedtoagent.Config.RequirePerServiceCallHistoryPersistenceagent/agent.go; provider/workflowAgentConfigstructs expose it through embeddedagent.Config. Pinned .NET 1.22.0 source declares the option onChatClientAgentOptionsand uses it to activate per-service-call history persistence.Discovery covered all 30 API-report entries and the recent patch areas through bounded
symbolmap-reviewerbatches. Removed APIs required no catalog deletion; provider-specific promoted history fields collapse to the single coreagent.Configmapping; agentmode and compaction candidates were already covered by prior closed mapping PRs #1218, #1220, and #1223, so they were not duplicated. Duplicate searches also found implementation PR #1201 for the history contract and no existing mapping edit for this property. Go-only input contained 0 entries; no Go-only changes were made. Reconciliation after the edit reports 840 assessed declarations, 728 linked, 112 outside inventory scope, 0 invalid Go targets, and 0 needs-reconciliation.Validation:
go mod download && go run ./cmd/symbolmap reconcile -summary -checkgit diff --checkOnly
docs/dotnet-go-sdk-symbol-mapping.jsonis committed. The worktree still has unrelated pre-existing changes to.github/skills/dotnet-symbols/SKILL.mdand untracked.github/agents/symbolmap-reviewer.agent.md, both left unstaged.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
proxy.golang.orgstorage.googleapis.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.