Skip to content

[symbolmap] Map per-service-call history persistence option - #1225

Merged
Quim Muntal (qmuntal) merged 2 commits into
mainfrom
copilot/symbolmap-history-persistence-20260929-b097fe53d087c098
Oct 1, 2026
Merged

Quim Muntal (qmuntal) merged 2 commits into
mainfrom
copilot/symbolmap-history-persistence-20260929-b097fe53d087c098

Conversation

@microsoft-agent-framework-for-go

Copy link
Copy Markdown
Contributor

Reviewed the supplied weekly symbolmap inputs starting at 2026-09-29T16:28:58Z with original assessed-mappings.json page.total = 839. Added review batch history-persistence-go-2026-09-29, pinned to .NET assembly metadata commit 0c9944cc9f577d51277ac7c55dbc388b60a577af, current Go commit 2b10117e67ea22a730c176567117537b720f45e0, and unchanged inventory SHA-256 734ff2c4037aa311de95912a256bb7e223ab3fa81a699835a21d27bab90f53ab.

Declaration Before After Evidence
ChatClientAgentOptions.RequirePerServiceCallChatHistoryPersistence Inventoried but unreviewed with no Go symbols mapped to agent.Config.RequirePerServiceCallHistoryPersistence Recent Go history-contract changes add and wire the field in agent/agent.go; provider/workflow AgentConfig structs expose it through embedded agent.Config. Pinned .NET 1.22.0 source declares the option on ChatClientAgentOptions and uses it to activate per-service-call history persistence.

Discovery covered all 30 API-report entries and the recent patch areas through bounded symbolmap-reviewer batches. Removed APIs required no catalog deletion; provider-specific promoted history fields collapse to the single core agent.Config mapping; agentmode and compaction candidates were already covered by prior closed mapping PRs #1218, #1220, and #1223, so they were not duplicated. Duplicate searches also found implementation PR #1201 for the history contract and no existing mapping edit for this property. Go-only input contained 0 entries; no Go-only changes were made. Reconciliation after the edit reports 840 assessed declarations, 728 linked, 112 outside inventory scope, 0 invalid Go targets, and 0 needs-reconciliation.

Validation:

  • go mod download && go run ./cmd/symbolmap reconcile -summary -check
  • git diff --check

Only docs/dotnet-go-sdk-symbol-mapping.json is committed. The worktree still has unrelated pre-existing changes to .github/skills/dotnet-symbols/SKILL.md and untracked .github/agents/symbolmap-reviewer.agent.md, both left unstaged.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • proxy.golang.org
  • storage.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "storage.googleapis.com"

See Network Configuration for more information.

Generated by Weekly Symbol Mapping Maintenance · copilot · gpt55 · 706.5 AIC · ⌖ 16.6 AIC · ⊞ 22.9K · ◷

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added size:small At most 30 changed lines across at most 2 files kind:docs Changes documentation or comments labels Sep 29, 2026
@qmuntal
Quim Muntal (qmuntal) marked this pull request as ready for review September 30, 2026 18:17
@qmuntal
Quim Muntal (qmuntal) requested a review from a team as a code owner September 30, 2026 18:17
Copilot AI balanced review requested due to automatic review settings September 30, 2026 18:17
@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Sep 30, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The mapping matches the verified .NET and Go declarations and includes valid pinned review metadata.

Review effort: Balanced
Findings: None

What changed in this PR

Adds the .NET per-service-call history persistence option to the Go SDK symbol mapping.

Changes:

  • Maps the .NET option to agent.Config.RequirePerServiceCallHistoryPersistence.
  • Adds pinned review provenance for the mapping.
File Description
docs/​dotnet-go-sdk-symbol-mapping.json Adds the reviewed history-persistence mapping and provenance.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Oct 1, 2026
@qmuntal

Copy link
Copy Markdown
Member

Copilot resolve conflicts

…tory-persistence-20260929-b097fe53d087c098

# Conflicts:
#	docs/dotnet-go-sdk-symbol-mapping.json

Co-authored-by: qmuntal <3747816+qmuntal@users.noreply.github.com>

Copilot AI commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Copilot resolve conflicts

Conflicts with origin/main have been resolved in commit bb0ca4d.

@qmuntal
Quim Muntal (qmuntal) added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit c35b127 Oct 1, 2026
21 checks passed
@qmuntal
Quim Muntal (qmuntal) deleted the copilot/symbolmap-history-persistence-20260929-b097fe53d087c098 branch October 1, 2026 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:docs Changes documentation or comments size:small At most 30 changed lines across at most 2 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants