Skip to content

[symbolmap] Update symbol mappings for recent agent APIs - #1218

Closed
microsoft-agent-framework-for-go[bot] wants to merge 1 commit into
mainfrom
symbolmap-maintenance-2026-09-29-b226aab-775f12bc9b08bfc8
Closed

microsoft-agent-framework-for-go[bot] wants to merge 1 commit into
mainfrom
symbolmap-maintenance-2026-09-29-b226aab-775f12bc9b08bfc8

Conversation

@microsoft-agent-framework-for-go

Copy link
Copy Markdown
Contributor

What changed

Reviewed the snapshot with original page.total = 839 assessed leaves starting at 2026-09-29T11:45:58Z, plus the listed recent first-parent Go commits through current b226aab1505b67d3b4a85e68a32b7b964aeda389. Added one review batch, symbolmap-maintenance-2026-09-29, pinned to .NET assembly metadata commit 0c9944cc9f577d51277ac7c55dbc388b60a577af and unchanged inventory SHA-256 734ff2c4037aa311de95912a256bb7e223ab3fa81a699835a21d27bab90f53ab.

Area Declaration Before After Cause / evidence
Agent mode AgentModeProvider.SetModeAsync(AgentSession, string, bool, CancellationToken) Unreviewed inventoried overload mapped to agent/harness/agentmode.Provider.SetMode Recent commit e16f7e7aacf892f6ad6228e3342a356650597836 changed SetMode to accept disableNotification bool; pinned inventory includes the bool overload.
Agent mode AgentModeProviderOptions.DisableModeGetTool Unreviewed inventoried property mapped to agent/harness/agentmode.Config.DisableModeGetTool Recent commit e16f7e7aacf892f6ad6228e3342a356650597836 added the Go config flag and tests; pinned inventory includes the .NET property.
Agent mode AgentModeProviderOptions.DisableModeSetTool Unreviewed inventoried property mapped to agent/harness/agentmode.Config.DisableModeSetTool Recent commit e16f7e7aacf892f6ad6228e3342a356650597836 added the Go config flag and tests; pinned inventory includes the .NET property.
Agent mode TodoCompletionLoopEvaluator.EvaluateAsync(LoopContext, CancellationToken) unmapped, but note referenced stale ModeForSession Go accessor Still unmapped; note now references Mode Recent commit e16f7e7aacf892f6ad6228e3342a356650597836 renamed the Go accessor to Provider.Mode; no built-in evaluator counterpart was found.
History compaction InMemoryChatHistoryProviderOptions.ChatReducer Unreviewed inventoried property adapted to agent/compaction.HistoryProviderConfig.Strategy Recent commit 7573f9ad4766abe418b6cbd97e111864c682bb21 added compaction.NewHistoryProvider with required Strategy; pinned inventory includes ChatReducer.
History compaction InMemoryChatHistoryProviderOptions.ReducerTriggerEvent Unreviewed inventoried property adapted to agent/compaction.HistoryProviderConfig.TriggerEvent Recent commit 7573f9ad4766abe418b6cbd97e111864c682bb21 added trigger timing for compaction-backed history; pinned inventory includes ReducerTriggerEvent.
History compaction InMemoryChatHistoryProviderOptions.ChatReducerTriggerEvent and constants BeforeMessagesRetrieval, AfterMessageAdded Unreviewed inventoried enum/constants adapted/mapped to agent/compaction.HistoryProviderTriggerEvent and its two constants Recent commit 7573f9ad4766abe418b6cbd97e111864c682bb21 added the Go trigger enum with matching before-retrieval and after-add timing.

Coverage and duplicate checks

Original assessed leaf coverage: 839/839 reviewed. New assessments added: 8 leaves (3 AgentMode leaves, 1 stale-note correction, 4 history-compaction leaves). Recent implementation PRs found by duplicate checks were #1111 and #1092, and the prior closed mapping PR was #1212; no open mapping edit was found for these catalog leaves. Issue search returned only low-integrity filtered tracker issues for some implementation terms, so their bodies were not inspected.

Validation

  • go mod download (to restore missing module cache for the symbolmap check)
  • go run ./cmd/symbolmap reconcile -summary -check
  • git diff --check

Only docs/dotnet-go-sdk-symbol-mapping.json is committed. The worktree still has an unrelated pre-existing modification to .github/skills/dotnet-symbols/SKILL.md, which was not staged or committed.

Warning

Firewall blocked 2 domains

The following domains were blocked by the firewall during workflow execution:

  • proxy.golang.org
  • storage.googleapis.com

To allow these domains, add them to the network.allowed list in your workflow frontmatter:

network:
  allowed:
    - defaults
    - "proxy.golang.org"
    - "storage.googleapis.com"

See Network Configuration for more information.

Generated by Weekly Symbol Mapping Maintenance · copilot · gpt55 · 166.8 AIC · ⌖ 12.2 AIC · ⊞ 23.8K · ◷

Add assessed mappings for recent AgentMode disable/notification controls and compaction-backed in-memory history reducer trigger counterparts. Also correct the stale TodoCompletionLoopEvaluator note that still referenced the old ModeForSession accessor.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added size:medium At most 100 changed lines across at most 5 files kind:docs Changes documentation or comments labels Sep 29, 2026
@qmuntal
Quim Muntal (qmuntal) deleted the symbolmap-maintenance-2026-09-29-b226aab-775f12bc9b08bfc8 branch September 29, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:docs Changes documentation or comments size:medium At most 100 changed lines across at most 5 files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant