Repository navigation
[symbolmap] Update symbol mappings for recent agent APIs - #1218
Closed
microsoft-agent-framework-for-go[bot] wants to merge 1 commit into
Closed
microsoft-agent-framework-for-go[bot] wants to merge 1 commit into
microsoft-agent-framework-for-go[bot] wants to merge 1 commit into
Conversation
Add assessed mappings for recent AgentMode disable/notification controls and compaction-backed in-memory history reducer trigger counterparts. Also correct the stale TodoCompletionLoopEvaluator note that still referenced the old ModeForSession accessor. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Quim Muntal (qmuntal)
deleted the
symbolmap-maintenance-2026-09-29-b226aab-775f12bc9b08bfc8
branch
September 29, 2026 12:07
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Reviewed the snapshot with original
page.total = 839assessed leaves starting at 2026-09-29T11:45:58Z, plus the listed recent first-parent Go commits through currentb226aab1505b67d3b4a85e68a32b7b964aeda389. Added one review batch,symbolmap-maintenance-2026-09-29, pinned to .NET assembly metadata commit0c9944cc9f577d51277ac7c55dbc388b60a577afand unchanged inventory SHA-256734ff2c4037aa311de95912a256bb7e223ab3fa81a699835a21d27bab90f53ab.AgentModeProvider.SetModeAsync(AgentSession, string, bool, CancellationToken)mappedtoagent/harness/agentmode.Provider.SetModee16f7e7aacf892f6ad6228e3342a356650597836changedSetModeto acceptdisableNotification bool; pinned inventory includes the bool overload.AgentModeProviderOptions.DisableModeGetToolmappedtoagent/harness/agentmode.Config.DisableModeGetToole16f7e7aacf892f6ad6228e3342a356650597836added the Go config flag and tests; pinned inventory includes the .NET property.AgentModeProviderOptions.DisableModeSetToolmappedtoagent/harness/agentmode.Config.DisableModeSetToole16f7e7aacf892f6ad6228e3342a356650597836added the Go config flag and tests; pinned inventory includes the .NET property.TodoCompletionLoopEvaluator.EvaluateAsync(LoopContext, CancellationToken)unmapped, but note referenced staleModeForSessionGo accessorunmapped; note now referencesModee16f7e7aacf892f6ad6228e3342a356650597836renamed the Go accessor toProvider.Mode; no built-in evaluator counterpart was found.InMemoryChatHistoryProviderOptions.ChatReduceradaptedtoagent/compaction.HistoryProviderConfig.Strategy7573f9ad4766abe418b6cbd97e111864c682bb21addedcompaction.NewHistoryProviderwith requiredStrategy; pinned inventory includesChatReducer.InMemoryChatHistoryProviderOptions.ReducerTriggerEventadaptedtoagent/compaction.HistoryProviderConfig.TriggerEvent7573f9ad4766abe418b6cbd97e111864c682bb21added trigger timing for compaction-backed history; pinned inventory includesReducerTriggerEvent.InMemoryChatHistoryProviderOptions.ChatReducerTriggerEventand constantsBeforeMessagesRetrieval,AfterMessageAddedadapted/mappedtoagent/compaction.HistoryProviderTriggerEventand its two constants7573f9ad4766abe418b6cbd97e111864c682bb21added the Go trigger enum with matching before-retrieval and after-add timing.Coverage and duplicate checks
Original assessed leaf coverage: 839/839 reviewed. New assessments added: 8 leaves (3 AgentMode leaves, 1 stale-note correction, 4 history-compaction leaves). Recent implementation PRs found by duplicate checks were #1111 and #1092, and the prior closed mapping PR was #1212; no open mapping edit was found for these catalog leaves. Issue search returned only low-integrity filtered tracker issues for some implementation terms, so their bodies were not inspected.
Validation
go mod download(to restore missing module cache for the symbolmap check)go run ./cmd/symbolmap reconcile -summary -checkgit diff --checkOnly
docs/dotnet-go-sdk-symbol-mapping.jsonis committed. The worktree still has an unrelated pre-existing modification to.github/skills/dotnet-symbols/SKILL.md, which was not staged or committed.Warning
Firewall blocked 2 domains
The following domains were blocked by the firewall during workflow execution:
proxy.golang.orgstorage.googleapis.comTo allow these domains, add them to the
network.allowedlist in your workflow frontmatter:See Network Configuration for more information.