Repository navigation
More optimized remainder calculation - #273
Merged
Merged
Conversation
Instead of division then remainder operation, used Math.DivRem which handles it in a more optimized way. It uses only a single division, multiplication, and subtraction instead of two divisions. Moreover, in the future, it can be even more optimized using intrinsics. See: dotnet/runtime#5213 (comment)
Contributor
|
It would be nice if this PR was acompanied by benchmarks. |
Contributor
Author
|
before: after: code: public class Test
{
private RecyclableMemoryStream subject;
private readonly byte[] bytes = new byte[] { 1, 2, 3, 4, 5, 6 };
[IterationSetup]
public void IterationSetup()
{
var manager = new RecyclableMemoryStreamManager();
this.subject = new RecyclableMemoryStream(manager);
}
[Benchmark]
public void WriteByte()
{
for (int i = 0; i < 10_000_000; i++)
{
this.subject.WriteByte(1);
}
}
[Benchmark]
public void WriteSpan()
{
for (int i = 0; i < 10_000_000; i++)
{
this.subject.Write(bytes.AsSpan());
}
}
} |
Contributor
|
I was thinking more in the lines of: public class Benchmarks
{
[Benchmark(Baseline = true)]
public (long quocient, long remainder) DivAndMod() => (4000L / 1024L, 4000L % 1024L);
[Benchmark]
public (long quocient, long remainder) MathDivRem() => Math.DivRem(4000L, 1024L);
}
|
Paulo Morgado (paulomorgado)
approved these changes
Feb 13, 2023
Gregory Bell (grbell-ms)
approved these changes
Feb 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of division then remainder operation, used Math.DivRem which handles it in a more optimized way. It uses only a single division, multiplication, and subtraction instead of two divisions. Moreover, in the future, it can be even more optimized using intrinsics.
See:
dotnet/runtime#5213 (comment)