Repository navigation
Add documention for json data files in mdn/content - #8100
Conversation
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2021-08-19 16:34:31.833199) |
sideshowbarker
left a comment
There was a problem hiding this comment.
Nice work. All I have are copy-editing nits.
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
Co-authored-by: Michael[tm] Smith <mike@w3.org>
|
Drive-by comment since I got email about all the commits: Use "Add suggestion to batch" to accept multiple suggestions at once. https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/incorporating-feedback-in-your-pull-request#applying-suggested-changes |
Oh, I didn't know about this feature! I usually edit the text, but as they were a lot I didn't! Thanks, and sorry! |
I don't know why, but for some reason this doesn't work on all repos. Is there a setting to enable it? |
There isn’t — as far I can see from checking the settings in other repos where I have admin perms. On thing, though, is that it only works when you review from the Files changed tab; e.g., https://github.com/mdn/content/pull/8100/files — it doesn’t work when you instead review from the Commits tab; e.g., https://github.com/mdn/content/pull/8100/commits |
If it doesn't work it might be because you're not on the "Files" tab. |
Fixes #8037
In #8019, @peterbe is migrating json files from mdn/yari to mdn/content.
This document the structure of the important ones.
It doesn't document the
l10n-*files that only tech-savvy localizers modify (and rarely, likely less than once a year), nor the svg-related one that is quite complex and in used on SVG that is practically unmaintained. This would not have been very useful, I think.But the two files used each week are documented, as well as
SpecData.jsondeprecated but we receive sometimes PRs for it.The links to the files on Github will start working only once #8019 has landed.