Repository navigation
Migrate kumascript jsondata to content repo - #8019
Merged
sideshowbarker merged 4 commits intoAug 21, 2021
Merged
sideshowbarker merged 4 commits into
sideshowbarker merged 4 commits into
Conversation
peterbe
requested review from
a team and
fiji-flo
and removed request for
a team and
fiji-flo
August 17, 2021 17:07
This was referenced Aug 18, 2021
Contributor
|
Should we merge this so we can start modifying these files here? Even if we won't use them before Yari's PR lands? |
Contributor
Author
|
I think so.
@escattone If you think we can get around to the yari side of this within days, I think we can go ahead with this here PR. In fact, then the content folks can start actually sending PRs to these even if it's a bit delayed till it actually appears in production builds. |
Contributor
|
@peterbe Yes, sounds good to me! |
Contributor
Author
So, mergy merge? |
sideshowbarker
approved these changes
Aug 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the company of mdn/yari#4081