Repository navigation
fix(test-layout): keep layout.json under the file-size threshold - #7943
Conversation
#7891 brought scripts/test-layout/layout.json to 2000 lines on dev, which the ratchet rejects as NEW_OVERSIZED. Move its registration onto the preceding windows line; the mapping is unchanged.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ Deterministic PR hygiene checks passed. |
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Combine Windows mappings scripts/test-layout/layout.json:1929 |
The two test mappings share one line. Their windows assignments are unchanged. |
Priority:
Estimated code review effort: 1 (Trivial) | ~2 minutes
Change: Bug fix
Suggested reviewers: luvs01, hedging8563
Merge Risk: 
16de0
-
The change only combines existing mappings on one JSON line and does not indicate a behavioral change.
Pre-merge checks: 
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title accurately describes the main change: updating scripts/test-layout/layout.jsonto keep the file below the file-size threshold without changing test mappings.Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Opt the one ordinary-successor cache case into a real synthetic caller admission while retaining its own thread and separate upstream bearer. Keep other native steering fixtures keyless by default and preserve all history assertions and wait budgets. Reproduced the same missing-admission timeout on clean 83fe2e6 and the published 571b3fe-equivalent tree. Full file: 33 passed; related native-control files: 106 passed. Independent one-file source review found no blocking finding. No product, layout, workflow, permission or timeout change. The inherited layout ratchet issue was already fixed upstream by maintainer PR #7943 and is not duplicated here.
Summary
devfailsfile-size ratchet: repositorysince #7891 (c7f3928):scripts/test-layout/layout.jsonreached 2000 lines, and the ratchet treats any file at 2000 lines or more that is missing from the baseline asNEW_OVERSIZED. #7891 was green at its own head becauselayout.jsonwas at 1998 lines there. The overflow only exists in the union with the PRs merged before it.This moves #7891's
windows-atomic-write-acl-rearm.test.tsregistration onto the precedingwindowsline. The mapping is unchanged and the file is back to 1999 lines.Verification
origin/deve1a60c2:bun test tests/ci-workflows/file-size-ratchet.test.ts→ 8 pass, 1 fail (scripts/test-layout/layout.json, 2000 lines,NEW_OVERSIZED).bun test tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/test-layout-tooling.test.ts→ 38 pass, 0 fail.Checklist
Summary by CodeRabbit