Skip to content

test(combo): update the failover e2e assertion the effort fix invalidated #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lidge-jun merged 1 commit into from
Sep 1, 2026
Merged

test(combo): update the failover e2e assertion the effort fix invalidated #3175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion tests/server-combo-failover-e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2205,7 +2205,13 @@ describe("server combo failover 030 activation matrix", () => {
expect(response.status).toBe(200);
expect(JSON.stringify(bodies[0]!.body)).not.toContain("data:image/png");
expect(JSON.stringify(bodies[1]!.body)).toContain("data:image/png");
expect(bodies[0]!.body.reasoning_effort).toBeUndefined();
// #3108: the combo default is resolved against each target's ladder rather than
// dropped on an exact-membership miss. This combo's advertised default IS "low" —
// the catalog intersects member ladders (a: ["low"], b: ["low","high"]) to ["low"]
// and effectiveComboDefault("high", ["low"]) yields "low" — so sending "low" to the
// first target is what the served catalog promised. Previously nothing was sent and
// the provider default silently applied.
expect(bodies[0]!.body.reasoning_effort).toBe("low");
expect(bodies[1]!.body.reasoning_effort).toBe("high");

clearComboSelectionState();
Expand Down
Loading