Repository navigation
test(combo): update the failover e2e assertion the effort fix invalidated - #3175
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
|
✅ Deterministic PR hygiene checks passed. |
github-actions
Bot
added
the
chore
5 tasks done
tarunravi
pushed a commit
to tarunravi/opencodex
that referenced
this pull request
Sep 14, 2026
…ated (lidge-jun#3175) The case expected the first target to receive no reasoning_effort, which is the behavior lidge-jun#3172 removed. That combo's members advertise low and low+high, so the catalog advertises low, and low is now what the first target receives. Refs lidge-jun#3108 Co-authored-by: jun <jun@lidge.dev>
agentHits
pushed a commit
to agentHits/opencodex
that referenced
this pull request
Sep 17, 2026
…ated (lidge-jun#3175) The case expected the first target to receive no reasoning_effort, which is the behavior lidge-jun#3172 removed. That combo's members advertise low and low+high, so the catalog advertises low, and low is now what the first target receives. Refs lidge-jun#3108 Co-authored-by: jun <jun@lidge.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI on
devcaught one assertion #3172 should have updated and did not:tests/server-combo-failover-e2e.test.ts > fresh child reparsing recomputes vision and effort per targetexpected the first target to receive noreasoning_effort.That expectation encoded the defect #3172 fixed. In that fixture the combo's members advertise
a: ["low"]andb: ["low", "high"], so the catalog intersects them to["low"]andeffectiveComboDefault("high", ["low"])resolves tolow— the served catalog advertiseslowfor this combo. The old request path tested literal membership, missed, and sent nothing, so the provider default applied. Sendinglowto the first target is what the catalog promised all along.The assertion is updated to
"low"with a comment recording why, rather than the fix being reverted. The second target still receiveshigh, which is what that half of the test was really checking.This is the follow-up to #3172 (
7386b52). No source change.Verification
Exact head:
bun test tests/server-combo-failover-e2e.test.ts— 74 pass, 0 fail, 453 expect() calls. The failing case reproduced locally before the change and passes after.bun test tests/combos.test.ts tests/combo-stream-preflight.test.ts tests/combo-child-headers.test.ts— 51 pass, 0 fail.Found by CI on the merged
devhead rather than by local review — the scoped local runs for #3172 coveredtests/combos.test.tsand the catalog and boundary suites, but not this end-to-end failover file.Checklist
dev