Skip to content

split ContainerCallback into sync and async parts - #533

Merged
matthyx merged 1 commit into
mainfrom
remove-blocking2
Apr 16, 2025
Merged

matthyx merged 1 commit into
mainfrom
remove-blocking2

Conversation

@matthyx

@matthyx matthyx commented Apr 15, 2025

Copy link
Copy Markdown
Contributor

@amitschendel better like that?

@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@amitschendel

Copy link
Copy Markdown
Contributor

Yes!
Is there a way to scale the worker pool dynamically instead of having to bump it manually?

@matthyx matthyx moved this from Triage to Needs Reviewer in KS PRs tracking Apr 15, 2025
@matthyx

matthyx commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

Yes! Is there a way to scale the worker pool dynamically instead of having to bump it manually?

// The maxWorkers parameter specifies the maximum number of workers that can
// execute tasks concurrently. When there are no incoming tasks, workers are
// gradually stopped until there are no remaining workers.

I think we can maybe give it twice the size of the callbacks? I am not sure this is something that will harm us too much

@matthyx matthyx added the release Create release label Apr 16, 2025
@amitschendel

Copy link
Copy Markdown
Contributor

This is better, sorry for being annoying but can you put a comment above the callback list that if there is more then 10 we should change the configuration?

@amitschendel
amitschendel self-requested a review April 16, 2025 12:30
Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx

matthyx commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

This is better, sorry for being annoying but can you put a comment above the callback list that if there is more then 10 we should change the configuration?

done

@github-actions

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx
matthyx merged commit 145325a into main Apr 16, 2025
@matthyx
matthyx deleted the remove-blocking2 branch April 16, 2025 13:08
@matthyx matthyx moved this from Needs Reviewer to To Archive in KS PRs tracking Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release Create release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants