Skip to content

split ContainerCallback into sync and async parts - #525

Closed
matthyx wants to merge 1 commit into
mainfrom
remove-blocking
Closed

matthyx wants to merge 1 commit into
mainfrom
remove-blocking

Conversation

@matthyx

@matthyx matthyx commented Apr 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

@matthyx
matthyx force-pushed the remove-blocking branch 2 times, most recently from 79b937b to 58d6f41 Compare April 8, 2025 13:34
@github-actions

github-actions Bot commented Apr 8, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: failure
  • Unit test: success
  • Go linting: success

Signed-off-by: Matthias Bertschy <matthias.bertschy@gmail.com>
@matthyx
matthyx changed the base branch from fix-processmanager to main April 9, 2025 08:45
@matthyx
matthyx marked this pull request as ready for review April 9, 2025 08:45
@github-actions

github-actions Bot commented Apr 9, 2025

Copy link
Copy Markdown

Summary:

  • License scan: failure
  • Credentials scan: failure
  • Vulnerabilities scan: success
  • Unit test: success
  • Go linting: success

@matthyx matthyx moved this to Needs Reviewer in KS PRs tracking Apr 9, 2025
@matthyx
matthyx requested a review from amitschendel April 9, 2025 12:37
@amitschendel

Copy link
Copy Markdown
Contributor

@matthyx How about instead of creating a worker pool in each manager, which is something that is hard to maintain during development, we will create one worker pool in the container watcher that takes a list of callbacks and streams the container notifications as today?

@matthyx

matthyx commented Apr 14, 2025

Copy link
Copy Markdown
Contributor Author

@matthyx How about instead of creating a worker pool in each manager, which is something that is hard to maintain during development, we will create one worker pool in the container watcher that takes a list of callbacks and streams the container notifications as today?

To be discussed, as we'll lose the parallel processing, so one callback type could slow down the others

@amitschendel

Copy link
Copy Markdown
Contributor

@matthyx How about instead of creating a worker pool in each manager, which is something that is hard to maintain during development, we will create one worker pool in the container watcher that takes a list of callbacks and streams the container notifications as today?

To be discussed, as we'll lose the parallel processing, so one callback type could slow down the others

Why? you can queue the callbacks in go routines.

@matthyx

matthyx commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

ok, let me think and propose another approach

@matthyx

matthyx commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

do you like it better #533 ?

@matthyx

matthyx commented Apr 15, 2025

Copy link
Copy Markdown
Contributor Author

superseded by #533

@matthyx matthyx closed this Apr 15, 2025
@matthyx
matthyx deleted the remove-blocking branch April 15, 2025 13:25
@matthyx matthyx moved this from Needs Reviewer to To Archive in KS PRs tracking Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants