Repository navigation
chore(codegen): resync cloud client from EF bc598db7 - #7455
Conversation
jrusso1020
left a comment
jrusso1020
left a comment
There was a problem hiding this comment.
Reviewed at c9c36b7a7bed16914a203c38a46ea7f683cb6a7d.
No blocker. The PR changes only packages/cli/src/cloud/_gen/types.ts: optional render bitrate fields, an optional image charge receipt with its named types, and nullable optional upload multipart (:81,110,136–137,696–718). Existing upload callers still omit multipart or send true; render callers retain the same request fields, and image consumers do not require the new receipt. No runtime transport, auth, charging policy or endpoint is changed.
I fetched both scripts/generate_hyperframes_cli_client.py and openapi/external-api.json at EF bc598db7dd98f6f0317d8d9024f795ea53eaa5c6, regenerated both outputs and applied the generator's two oxfmt passes. Through pytest-gate.sh python3 …/verify.py: types.ts and client.ts both match the PR byte-for-byte. This establishes generated provenance without hand edits. Checked the upload, render body and image create/poll consumers. No live API request or local full build claimed.
Exact-head hosted Typecheck, Build, Test, runtime contract, reachability, regression and both Windows contexts passed. Classic main protection returns no configured protection; the active ruleset lists 12 contexts: 10 succeeded, while Studio edit accuracy and skills manifest were skipped by the unchanged workflow's path conditions. Those skips are not executed tests.
Need: yes · Size: ok · Reuse: pinned EF OpenAPI and existing generator · Simpler: already minimal generated sync · Structure: fine (checked existing generated interfaces/client and upload/render/image consumers; no split)
Risk: low — additive declarations only; runtime client bytes unchanged.
— Rames / hf-review
Verdict: APPROVE
Reasoning: The committed output is exactly reproducible from its pinned source, and the type additions preserve current callers.
…ve more; advance watermark Twelve commits, PRs 7453-7468, issues 7457-7465 and eleven pin moves are recorded with their evidence in the continued ledger, DECISIONS and UPSTREAM. Adopted: heygen-com#7338, heygen-com#7459, heygen-com#7463, heygen-com#7454, heygen-com#7456 and the heygen-com#7439 docs; heygen-com#6732 was already ported. Deferred: heygen-com#7455, heygen-com#7437. Not applicable: heygen-com#7453, heygen-com#7269, heygen-com#7464. The watermark moves to 9e346f9, PR heygen-com#7468, issue heygen-com#7465; four new PRs are pinned and the eleven moved pins re-pinned at their current heads. FORK.md records the fork-only differences in the heygen-com#7338 port; the roadmap tracks the standalone scripts that keep a bare mkdtemp and issue heygen-com#7458. Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
Auto-generated PR: the HyperFrames cloud-render OpenAPI surface in experiment-framework changed. This PR regenerates the typed client in
packages/cli/src/cloud/_gen/.Generated by
scripts/generate_hyperframes_cli_client.py.Source commit: bc598db7dd98f6f0317d8d9024f795ea53eaa5c6
Triggered by: https://github.com/heygen-com/experiment-framework/commit/bc598db7dd98f6f0317d8d9024f795ea53eaa5c6