Skip to content

fix(skills): await the player seek in seam-gate - #7454

Merged
jrusso1020 merged 2 commits into
mainfrom
seam-gate-await-seek
Nov 9, 2026
Merged

jrusso1020 merged 2 commits into
mainfrom
seam-gate-await-seek

Conversation

@jrusso1020

Copy link
Copy Markdown
Collaborator

Problem

#7378 made __player.seek() asynchronous: it resolves once the preview picture is ready. seam-gate.mjs seeks and reads in the same tick, so every sample measures t=0. On a correct film, each seam fails the same way, with exit-visible op 0.00 and exit-moving 0 px/s, and probe finds no movers at all.

Found while building this week's changelog video (#7453). The committed gate reported 24 FAILs across 6 seams on a film whose frames are fine.

Changes

  • The page-side seek / sample / scan helpers are now async and await the seek. The three evalJs calls that use them pass awaitPromise, which evalJs already supports.
  • references/seam-gate.md gets a short note on the false-failure signature, so the next person recognizes it.
  • Both mirrors (.claude/ and .agents/) are updated identically.

Verification

  • On the Nov 2-9 changelog project, the committed gate reported 24 FAIL across 6 seams. This version reported 6/6 PASS with 0 warnings against the repo-local preview, on the same film.
  • In headless Chrome, a seek that isn't awaited leaves the timeline at 0, and an awaited seek lands at the requested time.
  • node --check passes and check-skill-mirror reports 24 files matching byte-for-byte.

— Rames

🤖 Generated with Claude Code

#7378 made __player.seek() asynchronous (it resolves once the preview
picture is ready). seam-gate.mjs seeked and read in the same tick, so
every sample measured t=0: on a correct film each seam failed with
exit-visible op 0.00 and exit-moving 0 px/s, and probe found no movers.

Make the page-side seek/sample/scan helpers async and evaluate them with
awaitPromise, and note the false-failure signature in the reference doc.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT · 0 blocker · 0 important · 1 nit
The fix itself is correct and ready to merge. I'm holding the approval only because CI on dfd2f84 is red, and that red isn't caused by this PR (see details).

  • nit: changelog-video/SKILL.md:158 and references/build-spec.md:122 (both mirrors) still say to spot-check "via __player.seek(t)". An agent that seeks and reads in one Runtime.evaluate will hit the same t=0 read. Saying "await __player.seek(t)" there would close that gap.
Scope / CI
  • I read all of seam-gate.mjs. All 4 __seamGate.sample/scan call sites now pass awaitPromise, and nothing else calls __seamGate.seek or __player.seek. Since #7378, __player.seek returns Promise<void> | void (HeldSeek, previewSeek.ts:340), and awaiting it works for both. evalJs already sets a 60 s CDP timeout, so a seek that never resolves fails loudly instead of hanging. node --check passes, and the two mirrors are byte-identical.
  • CI: the CI, preview-regression, Player perf, PR captures and Comments runs all failed with no failing job or step (every listed job is green or skipped). Since about 18:12Z every PR CI run has failed the same way, including the unrelated renovate/terraform-monorepo. That points to a repo-wide problem, not this diff. Re-run once it's fixed. CodeQL was still running when I posted.

— Genesis

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: COMMENT · 1 resolved, 0 open, 0 new · dfd2f84 → b8a354e. The code is ready; I'll approve once Actions shows CI green on this head.

CI on b8a354e

The CI, regression, preview-regression, Player perf and PR captures runs all concluded failure with no failing job. The required jobs Typecheck, Build, Test and regression were never created: CI shows only 7 jobs, all green, and regression shows only Detect changes. CI on main push has also failed this way since 18:11Z, so the cause is repo-wide, not this diff. mergeStateStatus is BLOCKED.

— Genesis

@heygengenesis heygengenesis Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE · 1 resolved, 0 open, 0 new · b8a354e (head unchanged). All 8 Actions runs on this head are now green, including the re-run CI (with Test, Test: skills, Format) and regression. Change detection skipped the package jobs because this is a skills-only diff.

— Genesis

@jrusso1020
jrusso1020 enabled auto-merge November 9, 2026 18:55
@jrusso1020
jrusso1020 added this pull request to the merge queue Nov 9, 2026
Merged via the queue into main with commit fc13420 Nov 9, 2026
74 checks passed
@jrusso1020
jrusso1020 deleted the seam-gate-await-seek branch November 9, 2026 19:27
@miguel-heygen miguel-heygen mentioned this pull request Nov 9, 2026
3 of 4 tasks
SanHsien added a commit to SanHsien/hyperframes that referenced this pull request Nov 9, 2026
…heygen-com#7456 and the heygen-com#7439 docs

heygen-com#7459: Studio renders take the same one-render-slot lock as the CLI and say
they are waiting; Cancel ends the wait.
heygen-com#7463: deleting an animated group parses its script once instead of once per
tween.
heygen-com#7454: seam-gate awaits the async player seek (both skill mirrors).
heygen-com#7456: the engine browser test project gets 30 s per test.
heygen-com#7439: current ChatGPT and Claude setup steps in the MCP guide.

Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
SanHsien added a commit to SanHsien/hyperframes that referenced this pull request Nov 9, 2026
…ve more; advance watermark

Twelve commits, PRs 7453-7468, issues 7457-7465 and eleven pin moves are
recorded with their evidence in the continued ledger, DECISIONS and UPSTREAM.
Adopted: heygen-com#7338, heygen-com#7459, heygen-com#7463, heygen-com#7454, heygen-com#7456 and the heygen-com#7439 docs; heygen-com#6732 was
already ported. Deferred: heygen-com#7455, heygen-com#7437. Not applicable: heygen-com#7453, heygen-com#7269, heygen-com#7464.
The watermark moves to 9e346f9, PR heygen-com#7468, issue heygen-com#7465; four new PRs are
pinned and the eleven moved pins re-pinned at their current heads. FORK.md
records the fork-only differences in the heygen-com#7338 port; the roadmap tracks the
standalone scripts that keep a bare mkdtemp and issue heygen-com#7458.

Co-Authored-By: Claude Sonnet <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant