Skip to content

fix(cli): mention hyperframes doctor after a browser download failure #7253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mertkayacs wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(cli): mention hyperframes doctor after a browser download failure #7253

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/cli/src/browser/manager.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1623,6 +1623,7 @@ describe("downloadBrowser — install failure surfaces HYPERFRAMES_BROWSER_PATH
expect(caught.message).toContain(rawMsg);
expect(caught.message).toContain("HYPERFRAMES_BROWSER_PATH");
expect(caught.message).toContain("No Chrome or Chromium was found on this machine");
expect(caught.message).toContain("hyperframes doctor");
expect(caught.message).not.toContain('export HYPERFRAMES_BROWSER_PATH="');
expect(caught.message).not.toContain("set HYPERFRAMES_BROWSER_PATH=");
expect(caught.cause).toBe(originalError);
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/src/browser/manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -721,7 +721,8 @@ function wrapDownloadFailureWithBrowserPathHint(
` export HYPERFRAMES_BROWSER_PATH="${installed}"\n\n` +
`Run \`hyperframes doctor\` to see which Chrome was found. Then re-run your command. `
: `No Chrome or Chromium was found on this machine. Install Google Chrome, then set ` +
`HYPERFRAMES_BROWSER_PATH to its executable and re-run your command. `;
`HYPERFRAMES_BROWSER_PATH to its executable. Run \`hyperframes doctor\` to see which ` +
`Chrome was found. Then re-run your command. `;
const message =
`Failed to install chrome-headless-shell ${managedChromeVersion()}: ${original}${unzipErrors}\n\n` +
pointAt +
Expand Down
Loading