Repository navigation
fix(cli): mention hyperframes doctor after a browser download failure - #7253
Open
mertkayacs wants to merge 1 commit into
Open
mertkayacs wants to merge 1 commit into
mertkayacs wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Verdict: REQUEST CHANGES · 1 blocker · 0 important · 0 nits · head a954196b
The code change looks right: the no-Chrome message now ends with the same hyperframes doctor step as the installed-Chrome branch, and it still doesn't guess an executable path.
- blocker (process): this repo requires every fix PR to name, in its body, a test that fails without the fix, on a line that starts with
fails without the fix:. This body says the test "fails onmain" but has no such line. For example:
- fails without the fix: manager.test.ts "downloadBrowser — install failure surfaces HYPERFRAMES_BROWSER_PATH…" no-Chrome cases (macOS, Windows, Linux): with main's manager.ts the message lacks "hyperframes doctor".
An edit to the body is enough; no new commit is needed.
Thanks for the contribution!
Contributor
There was a problem hiding this comment.
Verdict: APPROVE — 1 resolved, 0 open, 0 new · a954196 (body-only edit). The fails without the fix: line is present. I confirmed locally that the three no-Chrome cases in manager.test.ts fail with main's manager.ts and pass on this head (81/81). CI is green.
SanHsien
added a commit
to SanHsien/hyperframes
that referenced
this pull request
Nov 6, 2026
…view to heygen-com#7258 Adopts heygen-com#7306 (motion-blur composition counts in render_complete telemetry, adapted to discoverMovers; readEvents stays false without heygen-com#7191) and heygen-com#7318 (a set that interrupts a tween holds at any worker count) together with its merged prerequisite heygen-com#6851. PR axis advances to heygen-com#7258; heygen-com#7253 and heygen-com#7257 are open and pinned as monitored (97->99). Co-authored-by: Vance Ingalls <vance@heygen.com> Co-authored-by: Miguel Ángel <miguel.sierra@heygen.com> Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When the managed Chrome download fails and there is no system Chrome, the recovery message now ends with the same
hyperframes doctorstep the installed-Chrome message already has. The existing cross-platform table test covers that branch.Why
The no-Chrome message tells you to install Chrome and set
HYPERFRAMES_BROWSER_PATH, then stops, so there is no way to check that the path is right before re-running. This looks like it was dropped in #6954, which removed the guessed executable paths.On CI the runners ship Chrome, so
downloadStall.process.test.tstakes the installed-Chrome branch and passes. On a machine with no system Chrome it takes the no-Chrome branch and fails onmaintoday ("expected ... to contain 'hyperframes doctor'"); it passes with this change.How
Reuse the existing
hyperframes doctorsentence in the no-Chrome message, after theHYPERFRAMES_BROWSER_PATHinstruction, without guessing an executable path.Test plan
fails without the fix:
manager.test.ts"offers no path to export when no Chrome is installed, so a dead override is never suggested" (macOS, Windows and Linux cases): withmain'smanager.tsthe message has nohyperframes doctor.No-Chrome table test: 3 passed with the fix.
downloadStall.process.test.ts: 2 passed on a host without Chrome (1 of 2 fails onmain).The changed test passed 10 of 10 runs under CPU load.
Build, typechecks, lint, format, the comment gates, test reachability and the CLI lazy-dependency checks pass.
Both CLI shards ran locally. The two failures left (an FFmpeg-dependent HDR assertion and one timeout that passes when run alone) also show up on unmodified
main.Unit tests added/updated
Manual testing performed
Documentation updated (no command, flag or workflow changed)
Comments follow CONTRIBUTING.md "Comments" (no comments added or changed)