Repository navigation
fleet(#1394): display 'peer' for non-hub servers in sidebar and tooltips - #1395
Merged
Merged
Conversation
A server_mode='server' machine that isn't the canonical hub is a peer (ADR 0029). The sidebar type pill and tooltip now show 'peer' instead of 'server' for these machines. The canonical hub keeps 'server'. Adds displayRole(serverMode, isCanonicalHub) — exported and tested.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
jeonghun-jj-lee
added a commit
that referenced
this pull request
Sep 23, 2026
…ips (#1395) A server_mode='server' machine that isn't the canonical hub is a peer (ADR 0029). The sidebar type pill and tooltip now show 'peer' instead of 'server' for these machines. The canonical hub keeps 'server'. Adds displayRole(serverMode, isCanonicalHub) — exported and tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1394.
A
server_mode='server'machine that isn't the canonical hub now displays as peer in the sidebar type pill and tooltip (ADR 0029). The canonical hub keeps "server."Adds
displayRole(serverMode, isCanonicalHub)— exported and tested (4 new tests).