Repository navigation
fleet: rename "server" role label to "peer" for non-hub machines #1394
Description
Important
Problem — ADR 0029 models a fleet where every machine runs its own engine and can serve. The enroll primitive only has --as-server (hub) and --join-token (client). Re-enrolling a laptop as a "server" works mechanically but reads wrong in the sidebar — "server" implies the canonical hub, not a peer with its own engine.
Approach — Introduce a peer role (or display label) for machines that serve their own engine but aren't the canonical hub. The hub stays "server"; a peer is a machine with serving capability and its own engine. The roster's server_mode field, the sidebar label, and the enroll verb (--as-peer) all need updating.
Acceptance Criteria
- A new
--as-peerflag onamico fleet enrollenrolls a machine with its own engine (not a thin client) that is NOT the canonical hub - The roster's
server_modefield carries"peer"for these machines (or the display layer maps"server"to a friendlier label — design TBD) - The fleet sidebar shows a label that makes sense on a laptop (e.g. "Peer", "Node", or the machine's
device_type— not "Server") - The extension's
isFleetClientGuardallows engine spawn for peers (same as server) - Existing
serverandclientroles are unaffected
Context
- ADR 0029 calls these machines "peers" — a machine with
servingcapability - The
device_typefield (fleet: self-reported device identity (friendly name + device type) in the roster #1368, ADR 0028) already distinguishes desktop/laptop/devcontainer - Today: re-enrolling a MacBook Pro as
--as-serverworks but shows "Server" in the sidebar for a laptop
Source
Observed during fleet re-enrollment on the Mac Studio + MacBook Pro peer fleet.
Activity
fleet(#1394): display 'peer' for non-hub servers in sidebar and toolt…
fleet(#1394): display 'peer' for non-hub servers in sidebar and toolt…