Add MINIFS and MAXIFS functions - #1050
Merged
Merged
Conversation
Co-authored-by: Rene Kretzschmar <rkretzschmar@gmail.com>
sequba
marked this pull request as ready for review
August 23, 2022 11:37
sequba
commented
Aug 23, 2022
9 tasks
warpech
requested changes
Aug 24, 2022
warpech
left a comment
Member
There was a problem hiding this comment.
This is not full review yet, I just checked:
- changelog
- if the demo in CodeSandbox still works
- the docs changes in dev preview
Contributor
Author
|
@rkretzschmar Your general idea for the implementation of these two functions was good. I only made a few changes to comply with the standards of HyperFormula:
Once again, thanks for your contribution. You helped us a lot 🔥 |
Performance comparison of head (c9e5bb6) vs base (06047d2) |
warpech
approved these changes
Sep 5, 2022
warpech
left a comment
Member
There was a problem hiding this comment.
I reviewed the code and it looks good. Thanks for the code reuse in ConditionalAggregationPlugin.ts!
Codecov Report
@@ Coverage Diff @@
## develop #1050 +/- ##
========================================
Coverage 95.74% 95.74%
========================================
Files 161 161
Lines 14091 14098 +7
Branches 2974 2977 +3
========================================
+ Hits 13491 13498 +7
Misses 584 584
Partials 16 16
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
@rkretzschmar in #1047 wrote:
TODO:
SumifPlugin->ConditionalAggregationPluginConditionalAggregationPluginConditionalAggregationPluginCo-authored-by: Rene Kretzschmar rkretzschmar@gmail.com
How has this been tested?
Unit tests pass (including new test suites for MINIFS and MAXIFS
Types of changes
Related issues:
Fixes #1049
#1047
Checklist: