feat(function): add MINIFS and MAXIFS - #1047
Merged
sequba merged 1 commit intoAug 22, 2022
Merged
Conversation
rkretzschmar
marked this pull request as draft
August 13, 2022 17:46
rkretzschmar
force-pushed
the
feat-add-minmax-ifs
branch
from
August 13, 2022 18:08
76f6ba6 to
c118234
Compare
rkretzschmar
marked this pull request as ready for review
August 13, 2022 18:13
Contributor
|
Hi @rkretzschmar! Thank you very much for your contribution and for signing the Contributor License Agreement. We'll review the pull request shortly. |
Contributor
|
@rkretzschmar We will try to fit this into the upcoming release. |
Contributor
Author
Great, let me know if I can help. I am happy with refactoring the whole thing if necessary |
Contributor
@rkretzschmar Thanks a lot. I reviewed the code. You did a great job. I love the tests. I'll take care of all the details myself in #1050 |
20 tasks
Contributor
|
Hi @rkretzschmar I'm just here to share the great news, @sequba just released a new version of HyperFormula with your feature merged |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
MINIFSandMAXIFSto the built-in functionsi18n.spec.tsbuilt-in-functions.mdHow has this been tested?
function-minifs.spec.tsandfunction-maxifs.spec.tsTypes of changes
Related issues:
none
Checklist: