Repository navigation
[compiler-threat-spec] Daily compiler threat spec audit (2026-11-12) - #77018
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified, and the audit-only documentation changes are mapped to existing implementation and regression-test coverage without modifying compiler behavior.
No open issues 🎉
What changed in this PR
This audit-only pull request updates the compiler threat-detection specification to document existing credential-reference classification behavior without changing compiler implementation or adding a threat rule.
Changes:
- Bumps the specification to version 1.0.101 and clarifies wildcard, computed, whole-context, token, and secret-reference handling.
- Maps the documented requirements to existing implementation and regression-test coverage.
- Records the November 12 mapping audit and adds a patch changeset.
| File | Description |
|---|---|
| specs/compiler-threat-detection-spec.md | Updates the specification version and documents existing credential-reference requirements, implementation mapping, and test coverage. |
| specs/compiler-threat-detection-changelog.md | Adds the version 1.0.101 entry and records the November 12 mapping audit findings. |
| .changeset/threat-spec-audit-2026-11-12.md | Adds the patch changeset for the audit-only documentation update. |
Review effort: Lite (auto)
Contributor
Author
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit-only update, spec 1.0.101. No compiler behavior change.
Threats reviewed
isCredentialReference/valueUsesCredentialReference. Added the explicit requirement to CTR-010/017 and mapped it toTestCompileEnvCredentialReferences.threat-detection-suppressannotations, so no SLA breaches.Rule IDs
No
CTR-*rule added or changed. CTR-010/017 mappings were clarified.Files changed
specs/compiler-threat-detection-spec.md(version bump, sync table, normative text, test mapping)specs/compiler-threat-detection-changelog.md(1.0.101 version row and 2026-11-12 mapping audit).changeset/threat-spec-audit-2026-11-12.mdTests
Not run. The required Go 1.27.4 toolchain could not be downloaded in this sandbox, and the installed Go is 1.26.10. No Go source changed.
Changelog entry
### Mapping Audit (2026-11-12)and version row 1.0.101 inspecs/compiler-threat-detection-changelog.md.Steering issue #77012 had no comments.