Repository navigation
Harden temporary files for cache commits, MCP shell outputs, and installer logs - #76954
Merged
Merged
Conversation
…aller logs Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
pelikhan
marked this pull request as ready for review
November 11, 2026 20:26
Contributor
There was a problem hiding this comment.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Note
This error may be related to your runner configuration. You can now configure runners for Copilot code review separately from Copilot cloud agent by creating a copilot-code-review.yml file with your setup steps. Read the docs for details.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Collaborator
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
…orary-files # Conflicts: # actions/setup-cli/install.sh # install-gh-aw.sh # scripts/test-install-script.sh Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Contributor
Resolved and merged |
This was referenced Nov 12, 2026
Contributor
|
🎉 This pull request is included in a new release. Release: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the temporary-file handling reported by AI Scan alerts 1094, 1098, and 1087. Shared fixed paths can follow planted symlinks; shell-handler output creation also lacked exclusive allocation.
Validation
TMPDIR=/private/tmp make agent-report-progresspassed, including build, JavaScript lint, shell policy checks, and 15 shell-handler tests.Caveats
Validation ran on macOS, so existing Linux-only installer behavior cases were skipped. The canonical TMPDIR avoids an existing macOS cwd-path assertion mismatch; installer suites ran without ambient GH_TOKEN to preserve their checksum retry expectations. No live AI Scan rescan was performed.
Predictability exploitation of the former shell-handler suffix is not confirmed, and the cache diagnostic path is outside the ordinary agent shared
/tmp/gh-awmount, so ordinary-agent escape is not confirmed. Installer local exploitability depends on platform symlink protections and victim permissions. No alerts were dismissed or suppressed, and no workflows were dispatched.