Skip to content

metal : support qwen4exp hc ops - #29000

Merged
ggerganov merged 1 commit into
masterfrom
gg/metal-dsv4-hc-post
Sep 19, 2026
Merged

ggerganov merged 1 commit into
masterfrom
gg/metal-dsv4-hc-post

Conversation

@ggerganov

Copy link
Copy Markdown
Member

Overview

Support qwen4exp HC ops added in #28901 in Metal.

  • hc_pre: added gated variant (per-element sigmoid gate) and scale factor
  • hc_post: added identity variant (comb == nullptr, each stream keeps its own residual)

Ref: #28988

Requirements

@github-actions github-actions Bot added ggml changes relating to the ggml tensor library for machine learning Apple Metal https://en.wikipedia.org/wiki/Metal_(API) labels Sep 16, 2026
Add support for the new DSV4 HC op variants used by qwen4exp:
- hc_pre with per-element sigmoid gate (gated variant)
- hc_post with identity mixing (comb == nullptr)

Assisted-by: pi:llama.cpp/Qwen3.8-27B
@ggerganov
ggerganov force-pushed the gg/metal-dsv4-hc-post branch from 785b533 to 81264da Compare September 18, 2026 17:47
@ggerganov
ggerganov marked this pull request as ready for review September 18, 2026 17:47
@ggerganov
ggerganov requested a review from a team as a code owner September 18, 2026 17:47
@ggerganov
ggerganov merged commit 59fc5a1 into master Sep 19, 2026
36 of 40 checks passed
@ggerganov
ggerganov deleted the gg/metal-dsv4-hc-post branch September 19, 2026 08:27
@BrewTestBot BrewTestBot mentioned this pull request Sep 23, 2026
1 task done
LadislavSopko pushed a commit to 0ics-srls/llama.cpp that referenced this pull request Oct 5, 2026
Add support for the new DSV4 HC op variants used by qwen4exp:
- hc_pre with per-element sigmoid gate (gated variant)
- hc_post with identity mixing (comb == nullptr)

Assisted-by: pi:llama.cpp/Qwen3.8-27B
frostyautumnleaf pushed a commit to frostyautumnleaf/llama.cpp that referenced this pull request Oct 5, 2026
Add support for the new DSV4 HC op variants used by qwen4exp:
- hc_pre with per-element sigmoid gate (gated variant)
- hc_post with identity mixing (comb == nullptr)

Assisted-by: pi:llama.cpp/Qwen3.8-27B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apple Metal https://en.wikipedia.org/wiki/Metal_(API) ggml changes relating to the ggml tensor library for machine learning

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant