Repository navigation
v1.91.153.0 fix(outside-review): no-findings counts only as the review's conclusion; add regressions (#3294) - #3304
Merged
Conversation
…on; add regressions/defects (#3294) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…e/otherwise are exceptions; real codex captures Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ed Recommendation clauses; outside-review findings as controls Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…-findings-conclusion Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…wercase Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-findings-conclusion Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
Contributor
E2E Evals: ✅ PASS (reused: main moved, R2)No paid case ran on Verdict reuse (R2a restamp-only, R2 main moved): a changed own diff, a non-stamp byte, a changed selection, a newer red or unbound gate, or a missing binding or receipt runs the full gate; the evals-fresh label opts out. Free Tests and every other check still ran on this head. |
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-findings-conclusion
Closed
9 of 10 tasks
5 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3294. Thanks to @SchizasNik for the report and repro, and to @xg-gh-25 for pointing out the false-pass half.
What was wrong
classifyOutsideReviewaccepted a reply with no severity tags ascleanwhenever its no-findings regex matched anywhere in the text. Two consequences:cleanas soon as any "no X" phrase appeared, e.g. "The parser change has no new issues. However, db/002_drop_idx.sql drops users_email_idx…" passed /ship's structured gate.regressions, socodex review --uncommitted's clean reply "I found no actionable regressions in the staged, unstaged, or untracked changes." was recorded as missing coverage.What changed
concludesNoFindingsinlib/outside-review-result.ts). It must open the reply's last sentence or last ", and" clause, or thebecauseclause of a review'sRecommendation:line (wrapped continuation lines included), and carry no contrast or exception ("but", "however", "except", "other than", "elsewhere"…; "read-only" is not "only"). When other prose precedes it, anything after the statement except a predicate ("were found", "is evident") or a colon explanation must scope it to the change as a whole, so "No issues in the parser." or "No regressions were found by the existing tests." do not conclude the review.regressions/defects(singular too), and intro forms like "After reviewing the patch, I found no issues."NO_FINDINGSin inline code still counts.unverified/untagged_review; the reason code and itsdocs/troubleshooting.md#outside-review-unverifiedanchor are unchanged (owned bylib/gate-outcomes.ts). The "No findings" bullet indocs/troubleshooting.md#outside-review-verdictdescribes the new rule.Gate integrity
Gate edit: the structured and review gates' no-findings check in
classifyOutsideReview(stricter about position, wider in vocabulary). No threshold, trial count or case kind changed; no existing test was edited.New free regressions in
test/outside-review-result.test.ts:VERDICT: clean, exit 0;codex review --uncommittedreplies captured live from codex-cli 0.160.0 / gpt-6-sol on a scratch repo (bothunverifiedon main);unverifiedunder both the structured and review gates: the two strings from the issue thread, the phrase before / after / inside untagged findings, exception conclusions, conclusions scoped to one place or to the tests, a quotedNO_FINDINGS, a no-issues line inside a code fence;All four new tests fail against main's classifier. Every existing negative control passes unchanged (
outside-review-severity,outside-review-unparsed-severity,outside-voice-preflight), including the stored Codex clean review that still readsunverified("no actionable correctness issues" — vocabulary deliberately not widened beyond the report).An outside review by GPT-6.1 Sol probed for false passes; its realistic ones are now among the negative controls. Known residual, same as main: untagged findings followed by a conclusion that names the change ("No issues found in the changed parser.") still read
clean, since existing negative controls pin that phrasing as clean and the parser cannot tell a finding from a summary without tags. A clean review ending in a non-conclusion footer ("Tests: not run") now readsunverified(fail-closed).Validation
bun run test:ubicloud) at 59945ee: pass. One unrelated file,test/gstack-upgrade-fresh-shell.test.ts, failed once under parallel load and passed on the runner's serial retry (logged as flaky).test/run-in-background-guidance.test.ts: its stub review (<id>: current findings/No issues found./Recommendation: …) readunverifiedbecause the wrapped-line join glued the label line onto the conclusion. Now a line joins the one before only when it continues in lowercase, which fixes that test with no test edit. Two positive controls pin the rule. The remote pregate's diff selection had not picked that file.bun run typecheckandtypecheck:testreport no new diagnostics.bun run eval:select: no PR-profile paid cases are selected. codex-review, codex-review-findings and the outside-voice behaviors are deferred to broad coverage.