Repository navigation
outside-review-result: a clean structured review is unverified when Codex adds a check-results sentence after its conclusion #3469
Description
What happens
After #3304, a no-findings statement counts only when it is the review's conclusion. Codex's structured review (codex review --base main, codex-cli 0.163.0-alpha, model gpt-6-luna) often adds one sentence about the checks after its conclusion, so a clean review is recorded as VERDICT: unverified / REASON: untagged_review. In one /ship session, 2 of 3 structured runs ended like this:
No actionable regressions were identified in the diff. Tests, lint, and build all pass.
The changes introduce no definite, actionable regressions. Tests, lint, and build all pass.
lib/outside-review-result.ts structured on gstack 1.91.239.0:
| Review text | Verdict |
|---|---|
No actionable regressions were identified in the diff. |
clean |
Tests, lint, and build all pass. No actionable regressions were identified in the diff. |
clean |
No actionable regressions were identified in the diff. Tests, lint, and build all pass. |
unverified |
Suggestion
Let a short closing sentence that only reports check results (tests, lint, build or typecheck pass) follow the no-findings conclusion without moving the conclusion off it. The #3304 safeguards would still apply to the no-findings sentence itself: no "but / however / except" and scoped to the whole change. That keeps the false-pass protection while accepting the way Codex usually signs off.
Activity
itaywss commentedon Nov 4, 2026
Same on gstack 1.92.55.0 / codex-cli 0.166.0 (model gpt-6.1-sol), and on the
review(adversarial) gate, not onlystructured. Cleancodex execreplies come backVERDICT: unverified / REASON: untagged_reviewwhen they:Workaround we use: tell Codex to end its reply with a final line that says exactly NO_FINDINGS (after the Recommendation line).
fix(outside-review): a check-results sign-off keeps the no-findings c…
capy-ai commentedon Nov 7, 2026
Fixed in #4130 (e58be61): a clean Codex outside review that signs off with its checks ("Tests, lint, and build all pass.") now reads clean. A clause that follows the scope still never reads clean. It ships in the next gstack release after 1.98.0.0. Thanks for the report.