Skip to content

A test or bench body that assigns a module-level var gets a shadowing local, so the spec does not compile - #6833

Open
gHashTag wants to merge 2 commits into
masterfrom
queen-6771
Open

A test or bench body that assigns a module-level var gets a shadowing local, so the spec does not compile#6833
gHashTag wants to merge 2 commits into
masterfrom
queen-6771

Conversation

@gHashTag

@gHashTag gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Owner

Closes #6771

Written by a bee on queen-6771 and published by tools/queen/publish.py. The branch itself is the bee's; the second commit is the coordination entry every pull request must add, which a bee has no way to know about.

1 file changed, 105 insertions(+), 7 deletions(-)

🤖 Generated with Claude Code

Trinity Bee and others added 2 commits October 6, 2026 12:31
Trinity Bee
salvage(queen-6771): commit what the turn left uncommitted
e68f5d7 
The turn ended with these files edited and never committed. Uncommitted
work is invisible to the review - it reads the branch - so the attempt
would have been released as empty and the next bee would have started
beside this work rather than from it.

This commit is not a claim that the work is correct. It is the bee's
work, committed on its behalf, and it is judged exactly like any other:
the adversarial reviewer reads it, the compiler runs on it, and the
issue's own criteria are measured against it.

Issue: #6771
Turn: 1633ac49-47e7-45f3-a57c-cd3f65281fd1
Ending: finished (the turn closed)
Committed: 1 path(s)
Left uncommitted: 1 path(s) outside the declared boundary
@claude
docs: the coordination entry this branch needs to land
249934c 
A pull request must add exactly one docs/now entry and a bee has no way
to know that: its brief names a boundary file and acceptance criteria,
and docs/now/ is neither. The publisher adds it rather than failing the
gate.

Closes #6771

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-10-06 13:09:42 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 39
PRs with All Checks Green 11
READY 0
FAILING 39
PENDING 0
NO CHECKS YET 0

These columns do not partition: 0 + 39 + 0 + 0 = 39, and there are 50 open PRs. A PR is being counted twice or not at all.

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=40dad9861040 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

This was referenced Oct 6, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@gHashTag

gHashTag commented Oct 6, 2026

Copy link
Copy Markdown
Owner Author

Board check (queen-browser-social-round tick, 2026-10-06): Check L1 TRACEABILITY is red, and the reason is in the branch's own commit messages, not the diff.

  • 249934ca7 (coordination entry) carries Closes #6771 -- passes.
  • e68f5d799 (salvage(queen-6771): commit what the turn left uncommitted) carries only Issue: #6771. The L1 gate (.github/workflows/l1-traceability.yml, step "Check for Closes #N in commits") requires every commit in origin/master..HEAD to match the Closes|Fixes|Resolves|Refs|Updates #N pattern; Issue: #N matches none of them.

This is the salvage path, not the bee: a compare with queen-6414 (PR #6752, L1 green) shows its bee commit itself says Closes #6414. When a turn ends with uncommitted work, the engine's salvage commit template writes Issue: #N and drops the keyword, so every salvaged branch fails L1 at publish time. The template lives in the Queen engine (BrowserOS), so the fix is engine-side: the salvage message should say Closes #N when it is the claim-bearing commit for an open issue. Until then, salvaged branches need the keyword amended into the first commit before publish.

Recorded as a board defect; no changes made to this PR in this tick (merge discipline belongs to the night loop).

This was referenced Oct 6, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Open
Merged
Merged
Closed
Merged
This was referenced Oct 6, 2026
Open
Merged
Open
Merged
Merged
Open
Merged
Merged
Merged
Open
Merged
Open
Merged
Open
Merged
Closed
Open
Merged
Merged
Merged

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

A test or bench body that assigns a module-level var gets a shadowing local, so the spec does not compile

2 participants

@gHashTag @claude