Repository navigation
ci(fpga): fix fpga-build flags that broke fpga-synthesis on every PR - #1729
Merged
Merged
Conversation
fpga-build.yml passed `--board <X> --profile minimal` to `t27c fpga-build`, but that subcommand only defines --device/--minimal, so clap exited 2 with 'unexpected argument --board' -- making fpga-synthesis-arty red on every PR. Both are synth/smoke jobs where the exact device part is immaterial and the --device default (xc7a100tcsg324-1) is already the Arty A7-100T part matching the job's own chipdb placeholder, so --minimal alone is correct. Workflow-only change; no compiler change, no reseal. Closes #1723 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fpga-synthesis-arty(and the qmtech bitstream step) have been red on every PR becausefpga-build.ymlpasses flags thefpga-buildsubcommand doesn't define:The subcommand's clap spec has
--device <String>(defaultxc7a100tcsg324-1) and--minimal(bool) — no--board/--profile. It merged red on #1710/#1716/#1718/#1725/#1728.Fix
Both invocations →
--minimal. These are synth/smoke jobs where the exact device part is immaterial; the--devicedefaultxc7a100tcsg324-1is already the Arty A7-100T part and matches the job's own~/fpga/chipdb/xc7a100tcsg324-1.binplaceholder.Verified locally: the fixed command parses and proceeds to Verilog generation; the old
--boardform still errors (root cause). Workflow-only change; no compiler change, no reseal.Board-level UX (
--board/--profileas first-class flags) could be added CLI-side later if that abstraction is wanted.Closes #1723
🤖 Generated with Claude Code