Skip to content

ci(fpga): fix fpga-build flags that broke fpga-synthesis on every PR - #1729

Merged
gHashTag merged 1 commit into
masterfrom
fix/ci-fpga-build-flags
Aug 5, 2026
Merged

gHashTag merged 1 commit into
masterfrom
fix/ci-fpga-build-flags

Conversation

@gHashTag

@gHashTag gHashTag commented Aug 5, 2026

Copy link
Copy Markdown
Owner

fpga-synthesis-arty (and the qmtech bitstream step) have been red on every PR because fpga-build.yml passes flags the fpga-build subcommand doesn't define:

./target/release/t27c fpga-build --docker false --synth-only --board arty-a7 --profile minimal
# error: unexpected argument '--board' found  (exit 2)

The subcommand's clap spec has --device <String> (default xc7a100tcsg324-1) and --minimal (bool) — no --board/--profile. It merged red on #1710/#1716/#1718/#1725/#1728.

Fix

Both invocations → --minimal. These are synth/smoke jobs where the exact device part is immaterial; the --device default xc7a100tcsg324-1 is already the Arty A7-100T part and matches the job's own ~/fpga/chipdb/xc7a100tcsg324-1.bin placeholder.

Verified locally: the fixed command parses and proceeds to Verilog generation; the old --board form still errors (root cause). Workflow-only change; no compiler change, no reseal.

Board-level UX (--board/--profile as first-class flags) could be added CLI-side later if that abstraction is wanted.

Closes #1723

🤖 Generated with Claude Code

fpga-build.yml passed `--board <X> --profile minimal` to `t27c fpga-build`,
but that subcommand only defines --device/--minimal, so clap exited 2 with
'unexpected argument --board' -- making fpga-synthesis-arty red on every PR.
Both are synth/smoke jobs where the exact device part is immaterial and the
--device default (xc7a100tcsg324-1) is already the Arty A7-100T part matching
the job's own chipdb placeholder, so --minimal alone is correct.

Workflow-only change; no compiler change, no reseal.

Closes #1723

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

📓 NotebookLM Notebook linked to this PR

This notebook contains session context, decisions, and artifacts for this work.

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

PR Dashboard

Generated at: 2026-08-05 17:33:37 UTC

Summary

Status Count
Total Open PRs 50
PRs with Failing Checks 0
PRs with All Checks Green 50
READY 0
FAILING 0
PENDING 0

Seal Status

  • ⚠️ STALE -- sha256(compiler.rs)=864a709e6e17 != manifest seal=87e5cbd3ad94.
    The committed NMSE numbers were certified against an older compiler.rs.
    Run scripts/reseal-check.sh locally for the two-step reseal command (advisory; not a merge gate).

@gHashTag
gHashTag merged commit 6fcfe34 into master Aug 5, 2026
25 of 27 checks passed
@gHashTag
gHashTag deleted the fix/ci-fpga-build-flags branch August 5, 2026 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: fpga-synthesis-arty passes flags the fpga-build subcommand rejects (red on every PR)

1 participant