feat(codegen): gen-rust tuple literals + let (a,b) destructuring - #1716
Merged
Merged
Conversation
Adds NodeKind::ExprTuple (parsed when a comma follows in the '(' primary), a
tuple-pattern branch in parse_local_decl (stored in extra_field), an optimizer
guard keeping tuple-destructuring locals, and gen-rust emit for '(e0, e1)' and
'let (a, b) = init'. Tuple specs now rustc-compile end-to-end.
Regression test test_tuple_literal_and_destructuring_rust; full suite 1497/0;
FROZEN_HASH re-sealed. Part 2 of tuple support (#1702); Verilog/C TODO.
Closes #1715
gHashTag
enabled auto-merge
August 5, 2026 15:12
Contributor
|
📓 NotebookLM Notebook linked to this PR
This notebook contains session context, decisions, and artifacts for this work. |
Contributor
This was referenced Aug 5, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completes gen-rust tuple support (part 2 of #1702, after return-type #1709/#1710).
Tuple literals
(a, b)in returns andlet (s, d) = call()destructuring now emit valid Rust — previously they collapsed tounimplemented!()/let ;:Adds
NodeKind::ExprTuple(parsed when a comma follows in the(primary), a tuple-pattern branch inparse_local_decl(extra_field), an optimizer guard keeping tuple-destructuring locals, and gen-rust emit for both.Verified: new test
test_tuple_literal_and_destructuring_rust, generated Rust rustc-compiles, full suite 1497/0, non-tuple specs unaffected, FROZEN_HASH re-sealed. Verilog/C tuple lowering still TODO.Closes #1715