Repository navigation
Keep chats usable when a default secondary executor stalls - #16
Merged
Merged
Conversation
friel-openai
marked this pull request as ready for review
November 9, 2026 15:03
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unavailable default secondary executor should not prevent a chat from starting or continuing on healthy executors. Thread reads and resumes should not reread the same rollout metadata.
Keep admitted default selections intact, deny stdin to a quarantined secondary, and allow a healthy local executor to continue. Reuse the stored name for loaded metadata-only reads and the validated lineage for both backwards resume cursors.
The focused checks passed: 12 on the combined source and one on the successor that corrects only a test fixture ordering assumption. A native replay from the public tag and definition history matched the tested tree. Hosted CI still needs to pass, including the managed executor reconnect test.
This draft includes #14 and #15 to run required CI in parallel. Merge #14 and #15 first. Then verify the exact merge tree and required checks again before merging this draft. This PR does not publish a release or change a channel.
Codex Task:
codex://threads/01a029f4-9863-7523-be3e-864bebe4187a-frielbot