Repository navigation
Recover archived lineage migration across compression and mount boundaries - #14
Merged
Merged
Conversation
friel-openai
marked this pull request as ready for review
November 9, 2026 12:21
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
friel-openai
force-pushed
the
fix/archive-lineage-mount-recovery
branch
from
November 9, 2026 12:34
e948616 to
9a9b42d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Automatic history migration can leave an archived thread unreadable.
SQLite can still store the plain rollout path after compression, even
though the migration journal records the compressed file. Comparing the
journal path directly to the SQLite row makes publication retry without
progress. Publishing a rollout segment can also fail with
EXDEVwhenstaging and the destination are on different mounts.
Behavior
authenticated journal source. Use the exact stored path for the
compare-and-swap. A changed selection is not writer-lock contention.
EXDEV, copy the segment to a temporary file on the destinationmount, verify and sync it, then publish without overwriting an existing
target. Keep the staged bytes and legacy sources available for recovery.
The SQLite schema and journal format are unchanged. The existing hard
link for detached review inputs is unchanged.
Verification
before the fix. Thirteen focused thread-store tests passed after it,
including interrupted recovery, rejection of a changed selection, and
injected
EXDEVfor plain and compressed segments.exact tested tree. All 15 CI selector tests passed; the selector adds
the four new regression cases.
Codex Task:
codex://threads/01a029f4-9863-7523-be3e-864bebe4187a