Repository navigation
Add Memory helper lore dialogue for void runner - #2812
Merged
manuq merged 3 commits intoSep 2, 2026
Merged
Conversation
|
Test build no longer available. |
manuq
requested changes
Sep 1, 2026
| ~ help_accepted | ||
| Lore lore lore. | ||
| When I was young, I often wandered through these woods. I remember turning left to cross an old bridge, then heading left again into the forest. Among the trees, I would turn right and follow the trail of sand. Whenever I thought I was lost, I knew the signs to the Sanctuary would guide me home. | ||
|
|
Collaborator
There was a problem hiding this comment.
This empty line is not needed.
|
|
||
| ~ help_accepted | ||
| Lore lore lore. | ||
| When I was young, I often wandered through these woods. I remember turning left to cross an old bridge, then heading left again into the forest. Among the trees, I would turn right and follow the trail of sand. Whenever I thought I was lost, I knew the signs to the Sanctuary would guide me home. |
Collaborator
There was a problem hiding this comment.
This translates to 5 lines in the dialogue bubble. I think it would be better if you split the line in 2, so we get 2 dialogue bubbles:
Suggested change
| When I was young, I often wandered through these woods. I remember turning left to cross an old bridge, then heading left again into the forest. Among the trees, I would turn right and follow the trail of sand. Whenever I thought I was lost, I knew the signs to the Sanctuary would guide me home. | |
| When I was young, I often wandered through these woods. I remember turning left to cross an old bridge, then heading left again into the forest. | |
| Among the trees, I would turn right and follow the trail of sand. Whenever I thought I was lost, I knew the signs to the Sanctuary would guide me home. |
manuq
approved these changes
Sep 1, 2026
manuq
requested changes
Sep 1, 2026
|
|
||
| ~ help_accepted | ||
| Lore lore lore. | ||
| When I was young, I often wandered through these woods. I remember turning left to cross an old bridge, then heading left again into the forest. |
Collaborator
There was a problem hiding this comment.
@Leonardo-UTP the lint check https://github.com/endlessm/threadbare/actions/runs/33526256407/job/99917735218?pr=2812 fails for a boring reason: you have a trailing white space in this line. Please consider installing pre-commit like the contribution guide says.
manuq
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the placeholder Memory helper dialogue in the Void Runner quest with a short story that provides an indirect hint about the route through the level.
Fixes #2446