Repository navigation
Poison marker failure for xunit.abstractions.2.0.3 #3657
Description
As a result of the changes from dotnet/installer#17498, the following error occurs when attempting to set poison markers in the Fedora build leg of the VMR:
/vmr/eng/tools/init-build.proj(154,5): error MSB4018: The "MarkAndCatalogPackages" task failed unexpectedly.
/vmr/eng/tools/init-build.proj(154,5): error MSB4018: System.ArgumentException: Marker file name '.source-built.xml' is not sufficiently unique! Exists in '/vmr/prereqs/packages/previously-source-built/xunit.abstractions.2.0.3.nupkg'. (Parameter 'MarkerFileName')
/vmr/eng/tools/init-build.proj(154,5): error MSB4018: at Microsoft.DotNet.SourceBuild.Tasks.LeakDetection.MarkAndCatalogPackages.Execute() in /vmr/eng/tools/tasks/Microsoft.DotNet.SourceBuild.Tasks.LeakDetection/MarkAndCatalogPackages.cs:line 138
/vmr/eng/tools/init-build.proj(154,5): error MSB4018: at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
/vmr/eng/tools/init-build.proj(154,5): error MSB4018: at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)
Related build link (internal only)
Metadata
Metadata
Assignees
Type
Projects
- Status
Activity
MichaelSimons commentedon Oct 12, 2023
I suspect this is fallout from adding xunit.abstractions to SBRP. If so, this would be fixed with dotnet/source-build-assets@158cb6e which just flowed in dotnet/dotnet@1754673
MichaelSimons commentedon Oct 12, 2023
Thinking about this more, the problem won't be fixed until the assembly is removed from PSB.
NikolaMilosavljevic commentedon Oct 13, 2023
We need a fix for this. There are two copies of
xunit.abstractionsin PSB archive - one is the psb package, the other is the sbrp. Poison infra extracts to a temporary folder named after package identity, and doesn't clean package-specific content after repackaging it. When second package with the same exact identity is extracted to the same folder, there will already be the marker file and infra would fail, thinking that the marker is part of package contents.The solution would be to clean temporary folders as soon as they're not needed anymore. Working on a fix.
NikolaMilosavljevic commentedon Oct 13, 2023
Fixed with dotnet/installer#17527