Skip to content

.NET Source-Build 8.0.100-rc.2.23502.2 October 2023 Updates - #17498

Merged
mthalman merged 3 commits into
dotnet:release/8.0.1xxfrom
NikolaMilosavljevic:rel.80.october
Oct 11, 2023
Merged

mthalman merged 3 commits into
dotnet:release/8.0.1xxfrom
NikolaMilosavljevic:rel.80.october

Conversation

@NikolaMilosavljevic

Copy link
Copy Markdown

Source-build updates for the .NET 8.0.0-rc.2.23479.6 / 8.0.100-rc.2.23502.2 October 2023 release.

@NikolaMilosavljevic
NikolaMilosavljevic requested a review from a team as a code owner October 10, 2023 23:43
@MichaelSimons

Copy link
Copy Markdown
Member

Looks like there are some packages missing from the trusted feeds that will need to be mirrored.

@mthalman

Copy link
Copy Markdown
Member

Looks like there are some packages missing from the trusted feeds that will need to be mirrored.

The packages are mirrored correctly. The problem is that the SB artifacts being referenced define which versions are expected in the package feed. But the versions from the SB artifacts are not the same version as those that exist in the feed. This is related to dotnet/source-build#3521 where the build number produced by SB differs from the build number produced by the Microsoft build. To resolve this, we can override the SB version with the expected version that exists in the package feed.

@mthalman

Copy link
Copy Markdown
Member

The update in b2459d9 resolved the issue of prep. But now the build is failing:

/vmr/src/command-line-api/artifacts/source-build/self/src/src/System.CommandLine/System.CommandLine.csproj(0,0): error NU1102: (NETCORE_ENGINEERING_TELEMETRY=Restore) Unable to find package Microsoft.NET.ILLink.Tasks with version (>= 8.0.0-rc.2.23479.6)
  - Found 1 version(s) in previously-source-built [ Nearest version: 8.0.0-rc.2.23475.17 ]
  - Found 0 version(s) in source-built
  - Found 0 version(s) in prebuilt
  - Found 0 version(s) in reference-packages

This is because the Microsoft SDK we're dependent is configured to use the Microsoft-built version of ILLink in its BundledVersions.props file. So when attempting to build CommandLine, which uses trimming, the SDK attempts to load that Microsoft-built version of ILLink: 8.0.0-rc.2.23479.6. But the only version that exists in PSB is the SB version: 8.0.0-rc.2.23475.17.

@MichaelSimons

Copy link
Copy Markdown
Member

This is because the Microsoft SDK we're dependent is configured to use the Microsoft-built version of ILLink in its BundledVersions.props file. So when attempting to build CommandLine, which uses trimming, the SDK attempts to load that Microsoft-built version of ILLink: 8.0.0-rc.2.23479.6. But the only version that exists in PSB is the SB version: 8.0.0-rc.2.23475.17.

Can this be added as a custom bootstrap package? It would be needed in BootstrapOverrideVersionsProps as well as the buildBootstrapPreviouslySB.csproj

@mthalman mthalman closed this Oct 11, 2023
@mthalman mthalman reopened this Oct 11, 2023
@mthalman
mthalman enabled auto-merge (squash) October 11, 2023 19:59
@mthalman

Copy link
Copy Markdown
Member

Build is fixed. Please review.

@MichaelSimons MichaelSimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - friendly reminder to log a follow-up issue to clean this up after the next release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants