Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from dotnet/coreclr - #39594

Closed
dotnet-maestro[bot] wants to merge 2 commits into
masterfrom
darc-master-e4c4c505-0068-433e-8555-7fa6965c3359
Closed

[master] Update dependencies from dotnet/coreclr#39594
dotnet-maestro[bot] wants to merge 2 commits into
masterfrom
darc-master-e4c4c505-0068-433e-8555-7fa6965c3359

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request updates the following dependencies

From https://github.com/dotnet/coreclr

  • Build: 20190718.5
  • Date Produced: 7/19/2019 12:55 AM
  • Commit: a1e1fa3
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NET.Sdk.IL -> 5.0.0-alpha1.19368.5
    • Microsoft.NETCore.ILAsm -> 5.0.0-alpha1.19368.5
    • Microsoft.NETCore.Runtime.CoreCLR -> 5.0.0-alpha1.19368.5

@dotnet-maestro

dotnet-maestro Bot commented Jul 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful No un-ignored checks.

@MattGal

MattGal commented Jul 18, 2019

Copy link
Copy Markdown
Member

/azp run

@stephentoub stephentoub reopened this Jul 18, 2019
dotnet-maestro @safern
Update dependencies from https://github.com/dotnet/coreclr build 2019…
26f584a 
…0717.3

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19367.3
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19367.3
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19367.3
@safern
safern force-pushed the darc-master-e4c4c505-0068-433e-8555-7fa6965c3359 branch from 872cb97 to 26f584a Compare July 18, 2019 18:24
@wtgodbe

wtgodbe commented Jul 18, 2019

Copy link
Copy Markdown
Member

##[error].packages/microsoft.net.sdk.il/5.0.0-alpha1.19367.3/targets/Microsoft.NET.Sdk.IL.targets(140,5): error MSB3073: The command "/Users/vsts/agent/2.154.3/work/1/s/artifacts/toolset/ilasm/ilasm -QUIET -NOLOGO -DLL -INCLUDE=include/netcoreapp -OUTPUT="/Users/vsts/agent/2.154.3/work/1/s/artifacts/obj/System.Runtime.CompilerServices.Unsafe/netcoreapp-Debug/System.Runtime.CompilerServices.Unsafe.dll" -KEY="/Users/vsts/agent/2.154.3/work/1/s/.packages/microsoft.dotnet.arcade.sdk/1.0.0-beta.19365.4/tools/snk/MSFT.snk" System.Runtime.CompilerServices.Unsafe.il" exited with code 134.

Another Stack Overflow on OSX, looks to be the same as dotnet/core-setup#7251.

@janvorli can you take a look? I think this is related to your change dotnet/coreclr#25716

@wtgodbe wtgodbe mentioned this pull request Jul 18, 2019
Merged
@dotnet-maestro

dotnet-maestro Bot commented Jul 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS x64_Debug)

dotnet-maestro
Update dependencies from https://github.com/dotnet/coreclr build 2019…
534f00b 
…0718.5

- Microsoft.NET.Sdk.IL - 5.0.0-alpha1.19368.5
- Microsoft.NETCore.ILAsm - 5.0.0-alpha1.19368.5
- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19368.5
@janvorli

janvorli commented Jul 19, 2019

Copy link
Copy Markdown
Member

@wtgodbe I am sorry, I've missed that you've asked me to take a look. I'll look into it now.

@dotnet-maestro

dotnet-maestro Bot commented Jul 19, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS x64_Debug)

@janvorli

janvorli commented Jul 20, 2019 •
edited by stephentoub
Loading

Copy link
Copy Markdown
Member

@wtgodbe I've created a PR dotnet/coreclr#25803 to revert my MHR (Mojave Hardened Runtime) change that is causing this problem. I've found there are some issues there. I am leaving for a week of vacation, so I'll fix it once I'm back.

@dotnet-maestro

dotnet-maestro Bot commented Jul 20, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ All Checks Successful Unsuccessful checks: corefx-ci, corefx-ci (MacOS x64_Debug)

@stephentoub
stephentoub deleted the darc-master-e4c4c505-0068-433e-8555-7fa6965c3359 branch July 23, 2019 14:55
@karelz karelz added this to the 5.0 milestone Aug 3, 2019
@benaadams benaadams mentioned this pull request Feb 1, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.0

Development

Successfully merging this pull request may close these issues.

5 participants

@MattGal @wtgodbe @janvorli @stephentoub @karelz