Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

[master] Update dependencies from dotnet/coreclr - #7251

Merged
dotnet-maestro[bot] merged 4 commits into
masterfrom
darc-master-611295d5-c90f-46e3-a7c6-7fb2c5e60286
Jul 20, 2019
Merged

dotnet-maestro[bot] merged 4 commits into
masterfrom
darc-master-611295d5-c90f-46e3-a7c6-7fb2c5e60286

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented Jul 17, 2019 •

Copy link
Copy Markdown

This pull request updates the following dependencies

From https://github.com/dotnet/coreclr

  • Build: 20190720.1
  • Date Produced: 7/20/2019 12:41 PM
  • Commit: 1991a9ac761e8684ada594bc5a9fef0817c98602
  • Branch: refs/heads/master
  • Updates:
    • Microsoft.NETCore.Runtime.CoreCLR -> 5.0.0-alpha1.19370.1

…0717.1

- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19367.1
@dotnet-maestro

dotnet-maestro Bot commented Jul 17, 2019 •

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies Unsuccessful checks: dotnet.core-setup, dotnet.core-setup (Build_OSX release), dotnet.core-setup (Build_OSX debug), dotnet.core-setup (Build_Linux_x64_Alpine36 release)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

@wtgodbe

wtgodbe commented Jul 17, 2019

Copy link
Copy Markdown
Member

Some test failures on OSX:

[EXEC >] [....] [00:00:06.967] /Users/vsts/agent/2.154.1/work/1/s/bin/tests/osx-x64.Release/1/StandaloneApp/bundle/StandaloneApp
[EXEC -] [....] [00:00:06.973] Waiting for process 5840 to exit...
[EXEC <] [FAIL] [00:00:07.838] > /Users/vsts/agent/2.154.1/work/1/s/bin/tests/osx-x64.Release/1/StandaloneApp/bundle/StandaloneApp exited with 139
[xUnit.net 00:00:08.7975511] AppHost.Bundle.Tests.BundleExtractToSpecificPath.Bundle_extraction_is_reused [FAIL]
Failed AppHost.Bundle.Tests.BundleExtractToSpecificPath.Bundle_extraction_is_reused
Error Message:
Expected command to pass but it did not."\nFile Name: /Users/vsts/agent/2.154.1/work/1/s/bin/tests/osx-x64.Release/1/StandaloneApp/bundle/StandaloneApp\nArguments: \nExit Code: 139\nStdOut:\n\nStdErr:\n\n"

Stack Trace:
at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
at Microsoft.DotNet.CoreSetup.Test.CommandResultAssertions.Pass() in /Users/vsts/agent/2.154.1/work/1/s/src/test/TestUtils/Assertions/CommandResultAssertions.cs:line 33
at AppHost.Bundle.Tests.BundleExtractToSpecificPath.Bundle_extraction_is_reused() in /Users/vsts/agent/2.154.1/work/1/s/src/test/BundleTests/AppHost.Bundle.Tests/BundleExtractToSpecificPath.cs:line 73

Another example:

Error Message:
Expected command to pass but it did not."\nFile Name: /Users/vsts/agent/2.154.1/work/1/s/bin/tests/osx-x64.Release/3/AppWithSubDirs/bundle/AppWithSubDirs\nArguments: \nExit Code: 134\nStdOut:\n\nStdErr:\nStack overflow.\n\n"
Stack Trace:
at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
at FluentAssertions.Execution.AssertionScope.FailWith(String message, Object[] args)
at Microsoft.DotNet.CoreSetup.Test.CommandResultAssertions.Pass() in /Users/vsts/agent/2.154.1/work/1/s/src/test/TestUtils/Assertions/CommandResultAssertions.cs:line 33
at AppHost.Bundle.Tests.BundledAppWithSubDirs.RunTheApp(String path) in /Users/vsts/agent/2.154.1/work/1/s/src/test/BundleTests/AppHost.Bundle.Tests/BundledAppWithSubDirs.cs:line 24
at AppHost.Bundle.Tests.BundledAppWithSubDirs.Bundled_Framework_dependent_App_Run_Succeeds() in /Users/vsts/agent/2.154.1/work/1/s/src/test/BundleTests/AppHost.Bundle.Tests/BundledAppWithSubDirs.cs:line 44
Results File: /Users/vsts/agent/2.154.1/work/1/s/bin/tests/osx-x64.Release/AppHost.Bundle.Tests-testResults.trx

Looking. CC @dagood

@dagood

dagood commented Jul 17, 2019

Copy link
Copy Markdown
Member

CoreCLR diff (dotnet/coreclr@0cc81b6...7a97084) has a big-looking OSX-specific change, might be worth looking at if you haven't already: dotnet/coreclr#25716.

@wtgodbe

wtgodbe commented Jul 17, 2019

Copy link
Copy Markdown
Member

@janvorli does the failure look related to dotnet/coreclr#25716?

@dotnet-maestro

dotnet-maestro Bot commented Jul 18, 2019 •

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has not been merged because Maestro++ is waiting on the following merge policies.

  • ❌ Standard Merge Policies No un-ignored checks.
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

…0717.3

- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19367.3
@wtgodbe wtgodbe closed this Jul 18, 2019
@wtgodbe wtgodbe reopened this Jul 18, 2019
@wtgodbe

wtgodbe commented Jul 18, 2019

Copy link
Copy Markdown
Member

Commands like the following are all getting Stack Overflows on OSX:

exec --runtimeconfig /Users/vsts/agent/2.154.3/work/1/s/bin/tests/osx-x64.Debug/0/PortableTestApp/bin/PortableTestApp.runtimeconfig.json --depsfile /Users/vsts/agent/2.154.3/work/1/s/bin/tests/osx-x64.Debug/0/PortableTestApp/bin/PortableTestApp.deps.json --additionalProbingPath /Users/vsts/agent/2.154.3/work/1/s/packages /Users/vsts/agent/2.154.3/work/1/s/packages/dotnet-test-xunit/1.0.0-rc2-192208-24/lib/netcoreapp1.0/dotnet-test-xunit.dll /Users/vsts/agent/2.154.3/work/1/s/bin/tests/osx-x64.Debug/0/PortableTestApp/bin/PortableTestApp.dll

@wtgodbe

wtgodbe commented Jul 18, 2019

Copy link
Copy Markdown
Member

I've uploaded a formatted version of the error at https://github.com/wtgodbe/scratch/blob/master/StackOverflow.txt. Looks like we're trying to resolve references & get a Stack Overflow for some reason. building locally now.

@wtgodbe

wtgodbe commented Jul 18, 2019

Copy link
Copy Markdown
Member

Doesn't seem likely, but the CoreClr diff also includes dotnet/coreclr#25661, which is also OSX-specific (CC @jkotas)

@wtgodbe

wtgodbe commented Jul 18, 2019

Copy link
Copy Markdown
Member

Same thing is happening in the CoreClr -> CoreFx ingestion PR: dotnet/corefx#39594

@dotnet-maestro

dotnet-maestro Bot commented Jul 19, 2019 •

Copy link
Copy Markdown
Author

Auto-Merge Status

This pull request has been merged because the following merge policies have succeeded.

  • ✔️ Standard Merge Policies Succeeded - Successful checks: dotnet.core-setup, dotnet.core-setup (Build Windows_x86 release), dotnet.core-setup (Build Windows_x86 debug), dotnet.core-setup (Build Windows_x64 release), dotnet.core-setup (Build Windows_Arm64 release), dotnet.core-setup (Build Windows_x64 debug), dotnet.core-setup (Build Windows_Arm64 debug), dotnet.core-setup (Build Windows_Arm release), dotnet.core-setup (Build OSX Release), dotnet.core-setup (Build Windows_Arm debug), dotnet.core-setup (Build OSX Debug), dotnet.core-setup (Build Linux_x64_Rhel6 release), dotnet.core-setup (Build Linux_x64_glibc release), dotnet.core-setup (Build Linux_x64_Rhel6 debug), dotnet.core-setup (Build Linux_x64_glibc debug), dotnet.core-setup (Build Linux_Arm64_Alpine37 release), dotnet.core-setup (Build Linux_x64_Alpine36 release), dotnet.core-setup (Build Linux_Arm64_Alpine37 debug), dotnet.core-setup (Build Linux_x64_Alpine36 debug), dotnet.core-setup (Build Linux_Arm64 release), dotnet.core-setup (Build Linux_Arm release), dotnet.core-setup (Build Linux_Arm64 debug), dotnet.core-setup (Build Linux_Arm debug)
  • ✔️ Standard Merge Policies Succeeded - No reviews have requested changes.

dotnet-maestro added 2 commits July 19, 2019 00:55
…0718.5

- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19368.5
…0720.1

- Microsoft.NETCore.Runtime.CoreCLR - 5.0.0-alpha1.19370.1
@dotnet-maestro
dotnet-maestro Bot merged commit 42f12e0 into master Jul 20, 2019
@dotnet-maestro
dotnet-maestro Bot deleted the darc-master-611295d5-c90f-46e3-a7c6-7fb2c5e60286 branch July 20, 2019 13:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants