Repository navigation
test: resolve translations.json relative to repo (fixes red CI on #3) - #4
Merged
Merged
Conversation
…dcoded Windows path Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01THB2F2rFeFnc7MdEtoBhct
|
Welcome to UniversalInvoiceMail! Thank you for opening your first pull request. Please ensure all tests pass and your changes adhere to local-first privacy invariants. |
lukisch
commented
Nov 3, 2026
lukisch
left a comment
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Zweitmodell-Review (Cloud-Bot): freigabefähig, keine Blocker.
- Der Test
test_german_ui_texts_use_real_umlautsludtranslations.jsonüber einen hartcodierten Windows-Pfad (C:/_Local_DEV/...). Das scheitert auf jedem Runner. Der neue PfadPath(__file__).resolve().parents[1] / "locales" / "translations.json"ist repo-relativ und korrekt (die Testdatei liegt intests/). - CI auf diesem Head ist grün:
test (3.10/3.11/3.12),source-platform-smoke, CodeQL. - Merge-Reihenfolge: #4 vor oder zusammen mit #3 mergen, damit #3 auf
mainnicht rot bleibt. Die Freigabe bleibt beim Maintainer.
Generated by Claude Code
ellmos-multi-bot
approved these changes
Nov 3, 2026
ellmos-multi-bot
left a comment
ellmos-multi-bot
left a comment
Contributor
There was a problem hiding this comment.
Independent Siamese-twin technical review at exact head a29e016 (Gemini 4 Argon High, fresh independent Antigravity session).
Scope & Verification
- 1-file diff reviewed against origin/master:
- tests/test_ui_accessibility.py: Replaces hardcoded Windows absolute path \C:/_Local_DEV/repos/UniversalInvoiceMail/locales/translations.json\ with portable repo-relative resolution \Path(file).resolve().parents[1] / 'locales' / 'translations.json'.
- Portable across Linux and Windows CI runners.
- 0 edits to version or product files.
Test & CI Evidence
- GitHub Actions CI (Exact Head a29e016):
- All 10 checks completed with status SUCCESS (CodeQL actions/js/python, test 3.10/3.11/3.12, source-platform-smoke, assign, welcome).
- Mergeability: MERGEABLE, clean default base (master), 0 merge conflicts.
Verdict: PASS / APPROVE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
test_german_ui_texts_use_real_umlautshardcodesC:/_Local_DEV/repos/UniversalInvoiceMail/locales/translations.json, so it fails withFileNotFoundErroron any CI runner (test 3.10/3.11/3.12 red on #3).Fix
Resolve the path relative to the test file. The translation content itself passes the digraph check.
Generated by Claude Code