Repository navigation
fix(id-web): preserve other marks on inline code on save (#953) - #999
Conversation
create_marked_text early-returned a bare Code node when a code mark was present, discarding link/strong/em/strikethrough marks on the same text node. The Code node is now the innermost node and the remaining marks wrap it via build_mark_chain in the canonical nesting order. Also merge adjacent sibling mark wrappers with identical values when appending inline children (append_inline_child): [a `code` b](href) reaches save as three text nodes sharing the link mark, and three sibling Link nodes rendered as fragmented links. Merging emits one link containing all segments. Tests: 4 new round-trip fixpoint tests (code+link, code inside link text, code+strong/em/strikethrough, plain-code control); full web::markdown module 92/92 pass.
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 19 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Fixes #953.
Problem
create_marked_text(pkgs/id/src/web/markdown.rs) early-returned a bareCodenode when a code mark was present, discarding every other mark on the text node:[`code`](href)saved as`code`(link gone),code/code/code[acodeb](href)fragmented into three links with the code segment unlinked.Fix
Codenode is now the innermost node (code ranks innermost in the canonical nesting order, id(web): bold links flip spelling on every save — strong+link marks have no round-trip fixpoint #944); the remaining marks wrap it via the existingbuild_mark_chain, so combined marks survive save.append_inline_childmerge on inline append: adjacent sibling wrappers with identical values (same link url+title, strong, em, strikethrough) merge recursively. The[acodeb](href)case reaches save as three text nodes sharing the link mark; without merging, three siblingLinknodes render as fragmented links. With it, save emits one link containing all three segments.Tests
cargo test --features web --lib web::markdown— 92/92 pass (88 existing + 4 new), verified from a full output capture.cargo fmt --checkclean for the touched file.Queue task 1102 (repo-health-code-pilot).
Need help on this PR? Tag
@codesmith-botwith what you need.