Skip to content

ci(flake-inputs-update): cap failure excerpt from the tail, not the head - #918

Merged
dezren39 merged 1 commit into
mainfrom
creator/917-excerpt-tail
Oct 26, 2026
Merged

dezren39 merged 1 commit into
mainfrom
creator/917-excerpt-tail

Conversation

@dezren39

@dezren39 dezren39 commented Oct 25, 2026 •

Copy link
Copy Markdown
Member

Fixes #917

One-word fix in .github/workflows/flake-inputs-update.yml (:169): the failure-issue excerpt pipeline capped the filtered tail -n 80 selection with head -c 5000, keeping the first 5000 bytes — on any long failure the excerpt ended mid-line and the actual error never reached the tracking issue. Now tail -c 5000, so the excerpt ends with the log's final line. Same defect class and fix as openchamber #450 / PR #451.

Verification (synthetic probe, exact pipeline):

  • Long log (100 copying-path noise lines + 80 build lines + final error: builder … failed line): old excerpt = 5000 bytes ending mid-line in line 042, error absent (grep count 0); new excerpt = 5000 bytes ending with the error line (grep count 1).
  • Short log (filtered tail ≤5000 bytes): old and new excerpts byte-identical (cmp clean).
  • Workflow YAML parses (yaml.safe_load OK). Diff is workflow-YAML only, 1 line.

View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Summary by CodeRabbit

  • Bug Fixes
    • Failure logs now show the final portion of the filtered output, making recent errors easier to review.

head -c 5000 after tail -n 80 kept the first 5000 bytes of the last-80-lines selection, so on any long failure the excerpt ended mid-line and the actual error never reached the tracking issue. tail -c 5000 keeps the last 5000 bytes, ending with the log's final line; short logs are byte-identical.

Fixes #917
@dezren39
dezren39 requested a review from a team as a code owner October 25, 2026 22:12
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-25T22:13:39.502904Z 5191bf2 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 25, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d942b95e-0181-404f-9b4b-8b28d0ffa671
Commits

Reviewing files that changed from the base of the PR and between 21b7621 and 5191bf2.

Files selected for processing: 1
  • .github/workflows/flake-inputs-update.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The flake-inputs-update workflow now keeps the final 5,000 bytes of its filtered, last-80-line failure excerpt. It still removes copying path lines, replaces triple tildes, and treats excerpt-generation failures as non-fatal.

Changes: Failure log excerpt

Layer / File(s) Summary
Retain the final bytes
.github/workflows/flake-inputs-update.yml
The excerpt pipeline now uses tail -c 5000 to retain the final bytes of its filtered output.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Possibly related PRs

Merge Risk: Minimal · up to 5191b

The change preserves the end of long failure logs without changing short excerpts or issue reporting. No actionable merge-blocking risk remains.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: the CI failure excerpt now uses the tail rather than the head to enforce the 5,000-byte cap.
Linked Issues check Passed Issue #917 requires the filtered last 80 lines to retain the final 5,000 bytes, preserve copying path filtering and ~~~ neutralization, preserve short excerpts, and keep the workflow step otherwis…
Out of Scope Changes check Passed The whole-PR diff contains one workflow line in the failure-excerpt pipeline. The change directly implements issue #917 and does not add unrelated source, workflow, or documentation changes.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

Issue #917 requires the filtered last 80 lines to retain the final 5,000 bytes, preserve copying path filtering and ~~~ neutralization, preserve short excerpts, and keep the workflow step otherwise unchanged. The whole-PR diff changes only head -c 5000 to tail -c 5000 in .github/workflows/flake-inputs-update.yml. The pipeline order remains grep -v, tail -n 80, sed, then the byte cap. The PR reports synthetic verification for long and short logs and successful YAML parsing.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant