Repository navigation
ci(flake-inputs-update): cap failure excerpt from the tail, not the head - #918
Conversation
head -c 5000 after tail -n 80 kept the first 5000 bytes of the last-80-lines selection, so on any long failure the excerpt ended mid-line and the actual error never reached the tracking issue. tail -c 5000 keeps the last 5000 bytes, ending with the log's final line; short logs are byte-identical. Fixes #917
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Retain the final bytes .github/workflows/flake-inputs-update.yml |
The excerpt pipeline now uses tail -c 5000 to retain the final bytes of its filtered output. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix · Severity of issue fixed: Medium
Possibly related PRs
- developing-today/code#907: This PR introduced the workflow and its failure-log excerpt.
- developing-today/code#914: This PR changed filtering and tail-line selection in the same excerpt pipeline.
Merge Risk: 
Minimal · up to 5191b
-
The change preserves the end of long failure logs without changing short excerpts or issue reporting. No actionable merge-blocking risk remains.
Pre-merge checks: 
5
-
Full details: Linked Issues check
-
Explanation
Issue
#917requires the filtered last 80 lines to retain the final 5,000 bytes, preservecopying pathfiltering and~~~neutralization, preserve short excerpts, and keep the workflow step otherwise unchanged. The whole-PR diff changes onlyhead -c 5000totail -c 5000in.github/workflows/flake-inputs-update.yml. The pipeline order remainsgrep -v,tail -n 80,sed, then the byte cap. The PR reports synthetic verification for long and short logs and successful YAML parsing.
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Fixes #917
One-word fix in
.github/workflows/flake-inputs-update.yml(:169): the failure-issue excerpt pipeline capped the filteredtail -n 80selection withhead -c 5000, keeping the first 5000 bytes — on any long failure the excerpt ended mid-line and the actual error never reached the tracking issue. Nowtail -c 5000, so the excerpt ends with the log's final line. Same defect class and fix as openchamber #450 / PR #451.Verification (synthetic probe, exact pipeline):
error: builder … failedline): old excerpt = 5000 bytes ending mid-line in line 042, error absent (grep count 0); new excerpt = 5000 bytes ending with the error line (grep count 1).cmpclean).yaml.safe_loadOK). Diff is workflow-YAML only, 1 line.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit