Repository navigation
docs: record #392 and #418 completions in roadmap Done tables - #451
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf4c9f8c4b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | PR gate is one direct-Go job, Nix build only on dependency changes | 2026-10-18 | #295, `mcpx-nixbuild.yml` | | ||
| | mcpx is the single source; the `dezren39/nix` vendored copy is deleted and that flake builds from a pinned input of this repo | 2026-10-19 | #362, dezren39/nix#469 | | ||
| | Per-package 30m test timeout in the nix check phase | 2026-10-20 | #417 (for nix#510) | | ||
| | Darwin -skip override fails loudly on drift | 2026-10-20 | #445 (closes #418) | |
There was a problem hiding this comment.
Link the PR that actually implements the drift guard
The result points only to #445, but that PR merely adds comments and a test failure message; its own commit description says the actual throw, flake check, and CI evaluation that make drift fail loudly are implemented in dezren39/nix#543. A maintainer following this Done entry therefore cannot reach the implementation that substantiates the row, so include the downstream PR in the Result cell (as the roadmap already does for other cross-repository work).
Useful? React with 👍 / 👎.
Closes #450.
Adds the two missing Done rows verified in #450:
planning/roadmaps/repo-and-ci.md: PR fix(ci): push-to-main runs get their own concurrency group (run_id) in 9 workflows #428 (push-to-main runs get their ownrun_idconcurrency group, closes CI: push-to-main verification runs share one cancellable group — 11 of the last 18 id-check main runs were cancelled by the next merge #392).planning/roadmaps/mcpx.md: PR docs(mcpx): name the downstream darwin -skip coupling on the canonical checkPhase line #445 (this repo's half of the mcpx: the darwin skip override in dezren39/nix keys on this repo's check-phase line with a silent replaceStrings — no automated guard against drift #418 darwin -skip drift-guard set, alongside dezren39/nix PR id(world): F11.11 enforce the client projection with a structural test #543).Docs-only; diff is exactly +1 row per file.
python3 scripts/research_workflow.py check --repo-root .returns ok:true.Need help on this PR? Tag
@codesmith-botwith what you need.Summary by CodeRabbit