Skip to content

🎨 Palette: Add ARIA labels to empty icon buttons - #522

Merged
dezren39 merged 1 commit into
mainfrom
palette-a11y-aria-labels-9589846239344994825
Oct 23, 2026
Merged

dezren39 merged 1 commit into
mainfrom
palette-a11y-aria-labels-9589846239344994825

Conversation

@dezren39

@dezren39 dezren39 commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

🎨 Palette: Add ARIA labels to empty icon buttons

💡 What: Added aria-label attributes to the icon-only theme selection buttons and the inline tag "add" (+) button in the HTML templates.
🎯 Why: Screen readers often ignore title attributes on empty buttons, leaving users unaware of the button's purpose. Adding explicit aria-label attributes ensures assistive technologies correctly announce the action (e.g., "Sneak theme", "Add tag").
♿ Accessibility: Improved screen reader support for critical navigation and editing actions.


PR created automatically by Jules for task 9589846239344994825 started by @dezren39


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

- Added aria-labels to the theme selection buttons in `render_main_page_wrapper` and `render_editor`.
- Added aria-label to the inline tag `+` button in `render_editor`.

This improves screen reader accessibility by providing a textual description for empty buttons that only rely on titles or visual cues.

Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 56 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: d967fd0a-6049-4da5-be21-779d57e7afe7
📥 Commits

Reviewing files that changed from the base of the PR and between 0bbb55b and ac08985.

📒 Files selected for processing: 1
  • pkgs/id/src/web/templates.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@dezren39
dezren39 marked this pull request as ready for review October 23, 2026 00:28
@dezren39
dezren39 requested a review from a team as a code owner October 23, 2026 00:28
@dezren39
dezren39 merged commit b4038bb into main Oct 23, 2026
5 checks passed
@dezren39
dezren39 deleted the palette-a11y-aria-labels-9589846239344994825 branch October 23, 2026 00:28
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-23T00:29:45.514928Z ac08985 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant