Skip to content

🎨 Palette: Add aria-labels to empty buttons in templates - #326

Closed
dezren39 wants to merge 1 commit into
mainfrom
palette-add-aria-labels-templates-8061797394362157276
Closed

dezren39 wants to merge 1 commit into
mainfrom
palette-add-aria-labels-templates-8061797394362157276

Conversation

@dezren39

@dezren39 dezren39 commented Oct 19, 2026 •

Copy link
Copy Markdown
Member

🎨 Palette: Add aria-labels to empty buttons in templates

💡 What: Added aria-label attributes to the theme selector buttons and the inline tag addition + button in pkgs/id/src/web/templates.rs.
🎯 Why: These buttons are visually empty (theme selectors) or contain only an icon/single character (+), which makes them inaccessible to screen reader users without proper ARIA labels, even if they have visual title attributes.
♿ Accessibility: Significant improvement for screen reader users by properly labeling these interactive elements.

Also recorded a UX learning in .Jules/palette.md to establish a pattern of checking server-rendered templates for these missing attributes.


PR created automatically by Jules for task 8061797394362157276 started by @dezren39


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

Adds missing `aria-label` attributes to the empty theme selector buttons and the inline tag addition button (`+`) in the server-rendered HTML templates for better screen reader accessibility. Also records this UX learning pattern in `.Jules/palette.md`.

Co-authored-by: dezren39 <11225574+dezren39@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Oct 19, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@dezren39

Copy link
Copy Markdown
Member Author

Closing as obsolete: aria-labels on template buttons merged via #522/#199/#627

@dezren39 dezren39 closed this Oct 24, 2026
@google-labs-jules

Copy link
Copy Markdown
Contributor

Closing as obsolete: aria-labels on template buttons merged via #522/#199/#627

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

@dezren39
dezren39 deleted the palette-add-aria-labels-templates-8061797394362157276 branch November 2, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant