Skip to content

Fix request-scoped direct tool aliases - #3102

Open
dezren39 wants to merge 2 commits into
mainfrom
queue/4371-2770-request-scoped-alias
Open

dezren39 wants to merge 2 commits into
mainfrom
queue/4371-2770-request-scoped-alias

Conversation

@dezren39

@dezren39 dezren39 commented Oct 31, 2026 •

Copy link
Copy Markdown
Member

Summary

request tools and history → collision-safe aliases + request-scoped inverse
upstream function calls → restore only aliases applied for that request

Fixes #2770. When an alias is already a genuine tool, a distinct suffixed alias keeps both tools separate.

Evidence

  • Before: genuine run_command and terminal calls could be returned as shell and bash.
  • After: node --test bin/muse-proxy.test.mjs — 40 tests passed, covering chat and Responses, streaming and JSON, genuine names, and collisions. git diff --check passed.

Merge Danger

Door: two-way

Blast Radius: direct-mode tool calls


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@dezren39
dezren39 requested a review from a team as a code owner October 31, 2026 15:05
@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 45 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 63eb1806-e5d9-4cb5-ac60-2e3cc5a7db9a
Commits

Reviewing files that changed from the base of the PR and between 77f911f and cab9ea9.

Files selected for processing: 2
  • bin/muse-proxy.mjs
  • bin/muse-proxy.test.mjs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

CodeRabbit Verify

  • Run CodeRabbit Verify to test the changes in this pull request.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-11-03T17:22:26.139101Z
We couldn’t complete this review. Comment @codex review to try again.
cab9ea9 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@dezren39

dezren39 commented Nov 2, 2026

Copy link
Copy Markdown
Member Author

Stale-PR warden: no activity for 2 days. Resolution task: #4445 — this PR should be merged, fixed, or closed.

@dezren39

dezren39 commented Nov 3, 2026

Copy link
Copy Markdown
Member Author
state: needs-owner-decision
task: 7370
queue: repo-health-code-pilot
worker: repo-worker-code
lane: 335a5d1f-bfc1-4831-99ea-850c8939a727
at: 2026-11-03T10:50:00Z

Stale-PR triage read (no code touched — this PR is Drew-owned, leaving the decision to him):

Suggested owner action (Drew): rebase queue/4371-2770-request-scoped-alias onto current main, resolve both files, re-run node --test bin/muse-proxy.test.mjs, then merge — or close as abandoned and re-file if the #4626 rework supersedes it. Tracker: #4445.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant